diff --git a/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java b/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java index 845db622796..99881d032e2 100644 --- a/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java +++ b/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java @@ -30,14 +30,14 @@ private static AlertingSubsystem getAlertMonitor( AlertConfiguration.builder() .setType(AlertMetricType.CPU) .setEnabled(true) - .setThreshold((float) 80) + .setThreshold(80.0f) .setProfileDurationSeconds(30) .setCooldownSeconds(14400) .build(), AlertConfiguration.builder() .setType(AlertMetricType.MEMORY) .setEnabled(true) - .setThreshold((float) 20) + .setThreshold(20.0f) .setProfileDurationSeconds(120) .setCooldownSeconds(14400) .build(), @@ -89,14 +89,14 @@ void manualAlertWorks() { AlertConfiguration.builder() .setType(AlertMetricType.CPU) .setEnabled(true) - .setThreshold((float) 80) + .setThreshold(80.0f) .setProfileDurationSeconds(30) .setCooldownSeconds(14400) .build(), AlertConfiguration.builder() .setType(AlertMetricType.MEMORY) .setEnabled(true) - .setThreshold((float) 20) + .setThreshold(20.0f) .setProfileDurationSeconds(120) .setCooldownSeconds(14400) .build(), @@ -130,14 +130,14 @@ void manualAlertDoesNotTriggerAfterExpired() { AlertConfiguration.builder() .setType(AlertMetricType.CPU) .setEnabled(true) - .setThreshold((float) 80) + .setThreshold(80.0f) .setProfileDurationSeconds(30) .setCooldownSeconds(14400) .build(), AlertConfiguration.builder() .setType(AlertMetricType.MEMORY) .setEnabled(true) - .setThreshold((float) 20) + .setThreshold(20.0f) .setProfileDurationSeconds(120) .setCooldownSeconds(14400) .build(), diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java index 91541b4c1ca..d26cfd63881 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java @@ -43,7 +43,7 @@ void saneDataIsParsed() { AlertConfiguration.builder() .setType(AlertMetricType.CPU) .setEnabled(true) - .setThreshold((float) 80) + .setThreshold(80.0f) .setProfileDurationSeconds(30) .setCooldownSeconds(14400) .build()); @@ -53,7 +53,7 @@ void saneDataIsParsed() { AlertConfiguration.builder() .setType(AlertMetricType.MEMORY) .setEnabled(true) - .setThreshold((float) 20) + .setThreshold(20.0f) .setProfileDurationSeconds(120) .setCooldownSeconds(14400) .build()); diff --git a/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts b/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts index 3e91bc9a65b..b07b25d9e00 100644 --- a/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts +++ b/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts @@ -54,7 +54,6 @@ tasks { // Don't support Android without desugar disable("AndroidJdkLibsChecker") - disable("Java7ApiChecker") disable("StaticOrDefaultInterfaceMethod") // needed temporarily while hosting azure-monitor-opentelemetry-exporter in this repo @@ -70,6 +69,9 @@ tasks { // cognitive load is dubious. disable("YodaCondition") + // Requires adding compile dependency to JSpecify + disable("AddNullMarkedToPackageInfo") + if (name.contains("Jmh")) { disable("MemberName") } diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java index 4b49d56c53b..6c496723ded 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java @@ -56,6 +56,7 @@ public void setException(Throwable throwable, int stackSize) { this.throwable = throwable; } + @SuppressWarnings("EnumOrdinal") public void setSeverityLevel(SeverityLevel severityLevel) { data.setSeverityLevel( severityLevel == null @@ -65,6 +66,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) { } @Nullable + @SuppressWarnings("EnumOrdinal") public SeverityLevel getSeverityLevel() { return data.getSeverityLevel() == null ? null diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java index c8f3606d595..8d359901212 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java @@ -47,6 +47,7 @@ public void setMessage(String message) { data.setMessage(message); } + @SuppressWarnings("EnumOrdinal") public void setSeverityLevel(SeverityLevel severityLevel) { data.setSeverityLevel( severityLevel == null @@ -56,6 +57,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) { } @Nullable + @SuppressWarnings("EnumOrdinal") public SeverityLevel getSeverityLevel() { return data.getSeverityLevel() == null ? null diff --git a/dependencyManagement/build.gradle.kts b/dependencyManagement/build.gradle.kts index 1cab1ca3e40..e78e66229e8 100644 --- a/dependencyManagement/build.gradle.kts +++ b/dependencyManagement/build.gradle.kts @@ -33,7 +33,7 @@ val DEPENDENCY_BOMS = listOf( val autoServiceVersion = "1.1.1" val autoValueVersion = "1.11.0" -val errorProneVersion = "2.36.0" +val errorProneVersion = "2.38.0" val jmhVersion = "1.37" val mockitoVersion = "4.11.0" val slf4jVersion = "2.0.17" diff --git a/licenses/more-licenses.md b/licenses/more-licenses.md index 0364a813f0f..4bcb7f35daa 100644 --- a/licenses/more-licenses.md +++ b/licenses/more-licenses.md @@ -36,7 +36,7 @@ _2025-07-08 14:53:50 UTC_ > - **POM Project URL**: [http://stephenc.github.com/jcip-annotations](http://stephenc.github.com/jcip-annotations) > - **POM License**: Apache License, Version 2.0 - [https://www.apache.org/licenses/LICENSE-2.0](https://www.apache.org/licenses/LICENSE-2.0) -**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.36.0` +**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.38.0` > - **Manifest Project URL**: [https://errorprone.info/error_prone_annotations](https://errorprone.info/error_prone_annotations) > - **Manifest License**: Apache License, Version 2.0 (Not Packaged) > - **POM License**: Apache License, Version 2.0 - [http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0) diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java index e1e8e1afb18..4893de4d024 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java @@ -15,6 +15,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +@SuppressWarnings("TimeInStaticInitializer") public class MockedProfilerSettingsServlet extends HttpServlet { private static final Map CONFIGS;