Update Logback smoke test to use new assertion framework #4325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Logback smoke test to use the new assertion framework introduced in #4141, making the tests more readable and maintainable.
Changes Made
Extended Assertion Framework
MessageAssert: New assertion class forMessageDatawith fluent API methods likehasMessage(),hasSeverityLevel(),hasProperty(), etc.ExceptionAssert: New assertion class forExceptionDatawith methods likehasExceptionType(),hasExceptionMessage(),hasSeverityLevel(), etc.TraceAssert: AddedhasMessageSatisying(),hasExceptionSatisying(), andhasExceptionCount()methods to support message and exception assertionsUpdated Test Files
LogbackTest.java: Converted from manual assertion style to new framework usingwaitAndAssertTrace()LogbackLevelOffTest.java: Updated to use new assertion framework for cleaner implementationLogbackDisabledTest.java: Updated to use new assertion framework for consistencyBenefits
Before (old style):
After (new framework):
Improvements:
RequestAssert,DependencyAssert, andMetricAssertfrom Nicer smoke test assertions #4141Testing
spotlessApplyformattingThe changes maintain full backward compatibility while providing a cleaner, more maintainable testing experience aligned with the assertion framework introduced in #4141.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.