feedback

Author: jeremydvoss

CHANGELOG.md

@@ -2,12 +2,13 @@
 
 ## Unreleased
 
-## [1.0.0b11](https://github.com/microsoft/ApplicationInsights-Python/releases/tag/v1.0.0b11) - 2023-04-12
-
 - Remove most configuration for Public Preview
     ([#277](https://github.com/microsoft/ApplicationInsights-Python/pull/277))
 - Infer telemetry category disablement from exporter environment variables
     ([#278](https://github.com/microsoft/ApplicationInsights-Python/pull/278))
+
+## [1.0.0b11](https://github.com/microsoft/ApplicationInsights-Python/releases/tag/v1.0.0b11) - 2023-04-12
+
 - Reverse default behavior of instrumentations and implement configuration for exclusion
     ([#253](https://github.com/microsoft/ApplicationInsights-Python/pull/253))
 - Use entrypoints instead of importlib to load instrumentations

azure-monitor-opentelemetry/README.md

@@ -61,12 +61,12 @@ You can configure further with [OpenTelemetry environment variables][ot_env_vars
 | Environment Variable | Description |
 |-------------|----------------------|
 | [OTEL_SERVICE_NAME][opentelemetry_spec_service_name], [OTEL_RESOURCE_ATTRIBUTES][opentelemetry_spec_resource_attributes] | Specifies the OpenTelemetry [resource][opentelemetry_spec_resource] associated with your application. |
-| `OTEL_TRACES_EXPORTER` | If set to `None`, disables collection and export of distributed tracingtelemetry. |
-| `OTEL_METRICS_EXPORTER` | If set to `None`, disables collection and export of metric telemetry. |
 | `OTEL_LOGS_EXPORTER` | If set to `None`, disables collection and export of logging telemetry. |
+| `OTEL_METRICS_EXPORTER` | If set to `None`, disables collection and export of metric telemetry. |
+| `OTEL_TRACES_EXPORTER` | If set to `None`, disables collection and export of distributed tracing telemetry. |
 | `OTEL_BLRP_SCHEDULE_DELAY` | Specifies the logging export interval in milliseconds. Defaults to 5000. |
-| `OTEL_TRACES_SAMPLER_ARG` | Specifies the ratio of distributed tracing telemetry to be [sampled][application_insights_sampling]. Accepted values are in the range [0,1]. Defaults to 1.0, meaning no telemetry is sampled out. |
 | `OTEL_BSP_SCHEDULE_DELAY` | Specifies the distributed tracing export interval in milliseconds. Defaults to 5000. |
+| `OTEL_TRACES_SAMPLER_ARG` | Specifies the ratio of distributed tracing telemetry to be [sampled][application_insights_sampling]. Accepted values are in the range [0,1]. Defaults to 1.0, meaning no telemetry is sampled out. |
 <!-- TODO: add once OTEL_LOG_LEVEL is supported in sdk -->
 <!-- Specifies the [logging level][logging_level] of the logs you would like to collect for your logging pipeline. Defaults to 0 which is `logging.NOTSET`. | OTEL_LOG_LEVEL | -->
 

azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py

@@ -4,7 +4,7 @@
 # license information.
 # --------------------------------------------------------------------------
 from logging import getLogger
-from typing import Any, Dict
+from typing import Dict
 
 from azure.monitor.opentelemetry._constants import (
     DISABLE_LOGGING_ARG,
@@ -50,9 +50,6 @@
 )
 
 
-InstrumentationConfig = Dict[str, Dict[str, Any]]
-
-
 def configure_azure_monitor(**kwargs) -> None:
     """
     This function works as a configuration layer that allows the
@@ -103,7 +100,7 @@ def _setup_tracing(configurations: Dict[str, ConfigurationValue]):
 
 
 def _setup_logging(configurations: Dict[str, ConfigurationValue]):
-    # TODO: Remove after upgrading to 1.18
+    # TODO: Remove after upgrading to OTel SDK 1.18
     logging_export_interval_ms = configurations[LOGGING_EXPORT_INTERVAL_MS_ARG]
     logger_provider = LoggerProvider()
     set_logger_provider(logger_provider)