Move github release to separate job (#746)

* Move github release to separate job

Author: gfs

Pipelines/asa-release.yml

@@ -100,7 +100,7 @@ extends:
           outputs:
           - output: pipelineArtifact
             path: '$(Build.StagingDirectory)'
-            artifact: 'Signed_Binaries_$(System.JobId)_$(System.JobAttempt)'
+            artifact: 'Signed_Binaries'
           # see https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/outputs/nuget-packages
           - output: nuget
             useDotNetTask: false
@@ -111,6 +111,12 @@ extends:
             publishFeedCredentials: 'sdl-oss-nuget-publish'
         steps:
         - template: nbgv-set-version-steps.yml@templates
+        # set-version-steps only sets it for current job, while adding isOutput only sets it for future jobs
+        # https://learn.microsoft.com/en-us/azure/devops/pipelines/process/set-variables-scripts?view=azure-devops&tabs=powershell#set-an-output-variable-for-use-in-future-jobs
+        - powershell: |
+              $version = (nbgv get-version -v AssemblyInformationalVersion).split('+')[0]
+              Write-Host "##vso[task.setvariable variable=releaseVersion;isOutput=true]$version"
+          name: outputReleaseVersionVar
         - task: UseDotNet@2
           inputs:
             packageType: 'sdk'
@@ -547,6 +553,21 @@ extends:
             script: |
               mv $env:BUILD_BINARIESDIRECTORY/*.nupkg $env:BUILD_STAGINGDIRECTORY/
               mv $env:BUILD_BINARIESDIRECTORY/*.snupkg $env:BUILD_STAGINGDIRECTORY/
+      - job: gitHubReleaseJob
+        # Based on Documentation: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/releasepipelines/releaseworkflows/releasejob?tabs=standardreleasejob
+        displayName: GitHub Release Job
+        dependsOn: sign_hash_release
+        variables:
+          ReleaseVersion: $[ dependencies.sign_hash_release.outputs['outputReleaseVersionVar.releaseVersion'] ]
+        # pool: you can optionally specify pool as you would normally do for a standard job
+        templateContext:
+          type: releaseJob  # Required, this indicates this job is a release job
+          isProduction: true  # Required, must be 'true' or 'false'
+          inputs:  # All input build artifacts must be declared here
+          - input: pipelineArtifact  # Required, type of the input artifact
+            artifactName: Signed_Binaries  # Required, name of the pipeline artifact
+            targetPath: $(Pipeline.Workspace)/drop  # Optional, specifies where the artifact is downloaded
+        steps:
         - task: GitHubRelease@1
           displayName: Release to GitHub
           inputs: