Skip to content

Commit 89dea8e

Browse files
authored
[Subscription Billing] Make Subscription Billing Exchange Rate Selection reusable (#6080)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This commit exposes (makes public) the following functions so the standard Exchange Rate Selection flow from Subscription Billing can be reused by other extensions: Table 8059 “Subscription Line” - procedure OpenExchangeSelectionPage(...) Page 8088 “Exchange Rate Selection” - procedures: SetData(...), GetData(...), SetIsCalledFromServiceObject(...) Change: internal → public #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #6045 Fixes [AB#617698](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617698)
1 parent 00c2ec4 commit 89dea8e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Apps/W1/Subscription Billing/App/Service Commitments/Tables/SubscriptionLine.Table.al

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1332,7 +1332,7 @@ table 8059 "Subscription Line"
13321332
end;
13331333
end;
13341334

1335-
internal procedure OpenExchangeSelectionPage(var NewCurrencyFactorDate: Date; var NewCurrencyFactor: Decimal; CurrencyCode: Code[10]; NewMessageTxt: Text; CalledFromServiceObject: Boolean): Boolean
1335+
procedure OpenExchangeSelectionPage(var NewCurrencyFactorDate: Date; var NewCurrencyFactor: Decimal; CurrencyCode: Code[10]; NewMessageTxt: Text; CalledFromServiceObject: Boolean): Boolean
13361336
var
13371337
ExchangeRateSelectionPage: Page "Exchange Rate Selection";
13381338
begin

src/Apps/W1/Subscription Billing/App/Service Objects/Pages/ExchangeRateSelection.Page.al

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ page 8088 "Exchange Rate Selection"
6060
Error(CurrencyCodeChangePriceMustBeUpdatedErr);
6161
end;
6262

63-
internal procedure SetIsCalledFromServiceObject(CalledFromServiceObject: Boolean)
63+
procedure SetIsCalledFromServiceObject(CalledFromServiceObject: Boolean)
6464
begin
6565
IsCalledFromServiceObject := CalledFromServiceObject;
6666
end;
6767

68-
internal procedure SetData(NewKeyDate: Date; NewCurrencyCode: Code[10]; NewMessage: Text)
68+
procedure SetData(NewKeyDate: Date; NewCurrencyCode: Code[10]; NewMessage: Text)
6969
begin
7070
KeyDate := NewKeyDate;
7171
CurrencyCode := NewCurrencyCode;
@@ -75,7 +75,7 @@ page 8088 "Exchange Rate Selection"
7575
MessageTxt := NewMessage;
7676
end;
7777

78-
internal procedure GetData(var NewKeyDate: Date; var NewExchangeRate: Decimal)
78+
procedure GetData(var NewKeyDate: Date; var NewExchangeRate: Decimal)
7979
begin
8080
NewKeyDate := KeyDate;
8181
NewExchangeRate := ExchangeRate;

0 commit comments

Comments
 (0)