Skip to content

Commit 550befa

Browse files
authored
CSS Modules: convert remaining activity components to CSS modules (#5668)
* CSS Modules: remaining activity components * Update related * Migrate SayAlt component * Add carousel layout * Add tokens * Update PartGroupingDecorator * Format CSS * Optimize bubble * Adapt more to rtl and fix selectors * Fix specificalty * Fix removed prefixes * Tweak unspecified colors to be unset * snaps: follow fluent spacing * Changelog * Sort * Omit not needed amps * fix carousel spacers in fluent
1 parent 587b91b commit 550befa

30 files changed

+569
-237
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ Breaking changes in this release:
313313
- Bumped Chrome in Docker to 141 from 110, in PR [#5619](https://github.com/microsoft/BotFramework-WebChat/pull/5619), by [@compulim](https://github.com/compulim)
314314
- Bumped to [`[email protected]`](https://npmjs.com/package/valibot/v/1.2.0), in PR [#5650](https://github.com/microsoft/BotFramework-WebChat/pull/5650), by [@compulim](https://github.com/compulim)
315315
- Pinned to [`[email protected]`](https://npmjs.com/package/botframework-directlinespeech-sdk/v/4.18.1-main.20251208.8ccadd6), by [@OEvgeny](https://github.com/OEvgeny) in PR [#5662](https://github.com/microsoft/BotFramework-WebChat/pull/5662)
316+
- Converted remaining activity components to CSS Modules, in PR [#5668](https://github.com/microsoft/BotFramework-WebChat/pull/5668), by [@OEvgeny](https://github.com/OEvgeny)
316317

317318
### Deprecated
318319

__tests__/html2/accessibility/attachment/aria.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
await pageConditions.scrollToBottomCompleted();
3939

4040
const carouselContainer = document
41-
.querySelector('.webchat__carousel-filmstrip')
41+
.querySelector('.carousel-filmstrip')
4242
.getAttribute('aria-labelledby');
4343

4444
expect(carouselContainer).toBeFalsy();

__tests__/html2/accessibility/attachment/stackedLayoutRole.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
await pageConditions.minNumActivitiesShown(2);
2424
await pageConditions.scrollToBottomCompleted();
2525

26-
const attachmentRole = document.querySelector('.webchat__carousel-filmstrip-attachment').getAttribute('role');
26+
const attachmentRole = document.querySelector('.carousel-filmstrip-attachment').getAttribute('role');
2727

2828
expect(attachmentRole).toBeTruthy();
2929
});

__tests__/html2/accessibility/liveRegion/attachment/animationCard.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
await pageConditions.minNumActivitiesShown(2);
5252

5353
// Replace the animation with a static image.
54-
for (const imageElement of document.querySelectorAll('.webchat__bubble__content img')) {
54+
for (const imageElement of document.querySelectorAll('.bubble__content img')) {
5555
imageElement.setAttribute(
5656
'src',
5757
'https://raw.githubusercontent.com/compulim/BotFramework-MockBot/master/public/assets/surface1.jpg'

__tests__/html2/carousel/flipperButton.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
await pageConditions.numActivitiesShown(2);
2424

2525
// GIVEN: Carousel is at left most position.
26-
const carouselLayout = document.querySelector('.webchat__carousel-layout');
27-
const carouselFilmstrip = carouselLayout.querySelector('.webchat__carousel-filmstrip');
26+
const carouselLayout = document.querySelector('.carousel-layout');
27+
const carouselFilmstrip = carouselLayout.querySelector('.carousel-filmstrip');
2828

2929
expect(carouselFilmstrip.scrollLeft).toBe(0);
3030

__tests__/html2/carousel/flipperButton.rtl.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
await pageConditions.numActivitiesShown(2);
2525

2626
// GIVEN: Carousel is at left most position.
27-
const carouselLayout = document.querySelector('.webchat__carousel-layout');
28-
const carouselFilmstrip = carouselLayout.querySelector('.webchat__carousel-filmstrip');
27+
const carouselLayout = document.querySelector('.carousel-layout');
28+
const carouselFilmstrip = carouselLayout.querySelector('.carousel-filmstrip');
2929

3030
expect(carouselFilmstrip.scrollLeft).toBe(0);
3131

__tests__/html2/carousel/navigation.tab.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
);
5656
await pageConditions.stabilized(
5757
'carousel',
58-
() => document.querySelector('.webchat__carousel-filmstrip').scrollLeft,
58+
() => document.querySelector('.carousel-filmstrip').scrollLeft,
5959
5,
6060
5000
6161
);
@@ -70,7 +70,7 @@
7070
);
7171
await pageConditions.stabilized(
7272
'carousel',
73-
() => document.querySelector('.webchat__carousel-filmstrip').scrollLeft,
73+
() => document.querySelector('.carousel-filmstrip').scrollLeft,
7474
5,
7575
5000
7676
);

__tests__/html2/fluentTheme/carousel.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@
5555
await pageConditions.numActivitiesShown(2);
5656

5757
// WHEN: Right flipper is clicked.
58-
const carouselLayout = document.querySelector('.webchat__carousel-layout');
59-
const carouselFilmstrip = carouselLayout.querySelector('.webchat__carousel-filmstrip');
58+
const carouselLayout = document.querySelector('.carousel-layout');
59+
const carouselFilmstrip = carouselLayout.querySelector('.carousel-filmstrip');
6060
const rightFlipper = carouselLayout.querySelector('[aria-label="Next"]');
6161

6262
// Improve test reliability by hover before click on flipper button.
90 Bytes
Loading
307 Bytes
Loading

0 commit comments

Comments
 (0)