Skip to content

Commit b8435f4

Browse files
authored
* Bump [email protected] * Update entry * Fix tests
1 parent fa77780 commit b8435f4

File tree

5 files changed

+91
-165
lines changed

5 files changed

+91
-165
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
2424

2525
### Added
2626

27-
- Resolved [#4643](https://github.com/microsoft/BotFramework-WebChat/issues/4643). Decoupling `botframework-directlinejs` from business logic of Web Chat for better tree-shaking, by [@compulim](https://github.com/compulim), in PR [#4645](https://github.com/microsoft/BotFramework-WebChat/pull/4645)
27+
- Resolved [#4643](https://github.com/microsoft/BotFramework-WebChat/issues/4643). Decoupling `botframework-directlinejs` from business logic of Web Chat for better tree-shaking, by [@compulim](https://github.com/compulim), in PR [#4645](https://github.com/microsoft/BotFramework-WebChat/pull/4645) and PR [#4648](https://github.com/microsoft/BotFramework-WebChat/pull/4648)
2828

2929
### Fixed
3030

__tests__/html/suggestedActions.scroll.html

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@
2525
await pageConditions.numActivitiesShown(2);
2626

2727
// WHEN: The right flipper button is clicked.
28-
document.querySelector('[aria-label="Suggested actions"] [aria-label="right"]').click();
29-
30-
// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
31-
// document.querySelector('[aria-label="Suggested actions"] [aria-label="next"]').click();
28+
document.querySelector('[aria-label="Suggested actions"] [aria-label="Next"]').click();
3229

3330
// THEN: It should scroll to the right.
3431
await pageConditions.became(
@@ -38,10 +35,7 @@
3835
);
3936

4037
// WHEN: The left flipper button is clicked.
41-
document.querySelector('[aria-label="Suggested actions"] [aria-label="left"]').click();
42-
43-
// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
44-
// document.querySelector('[aria-label="Suggested actions"] [aria-label="previous"]').click();
38+
document.querySelector('[aria-label="Suggested actions"] [aria-label="Previous"]').click();
4539

4640
// THEN: It should scroll back to the origin.
4741
await pageConditions.became(

__tests__/html/suggestedActions.scroll.rtl.html

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@
2626
await pageConditions.numActivitiesShown(2);
2727

2828
// WHEN: The right flipper button is clicked.
29-
document.querySelector('[aria-label="Suggested actions"] [aria-label="left"]').click();
30-
31-
// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
32-
// document.querySelector('[aria-label="Suggested actions"] [aria-label="next"]').click();
29+
document.querySelector('[aria-label="Suggested actions"] [aria-label="Next"]').click();
3330

3431
// THEN: It should scroll to the right.
3532
await pageConditions.became(
@@ -39,10 +36,7 @@
3936
);
4037

4138
// WHEN: The left flipper button is clicked.
42-
document.querySelector('[aria-label="Suggested actions"] [aria-label="right"]').click();
43-
44-
// TODO: This will be updated from "left/right" to "next/previous" when the carousel support customizing the aria-label. Commented out for now.
45-
// document.querySelector('[aria-label="Suggested actions"] [aria-label="previous"]').click();
39+
document.querySelector('[aria-label="Suggested actions"] [aria-label="Previous"]').click();
4640

4741
// THEN: It should scroll back to the origin.
4842
await pageConditions.became(

0 commit comments

Comments
 (0)