diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 48bf24ec0d..e52201de5d 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -18,9 +18,9 @@ body: label: Is it an issue related to Adaptive Cards? description: If yes, please verify if this issue repro on [Adaptive Cards Designer](https://adaptivecards.io/designer/). If it repro on their designer, please [file an issue to their repository](https://github.com/microsoft/AdaptiveCards/issues/new/choose). options: - - "" + - '' - Yes, this is an Adaptive Card issue, however it only repro on Web Chat. - - "No" + - 'No' validations: required: true - type: dropdown @@ -28,8 +28,8 @@ body: label: Is this an accessibility issue? description: For accessibility issue, please use [this issue template](https://github.com/microsoft/BotFramework-WebChat/issues/new?template=accessibility.yml). options: - - "" - - "No" + - '' + - 'No' validations: required: true - type: dropdown @@ -85,28 +85,29 @@ body: description: Please make sure the issue continued to repro on latest version of the browser. multiple: true options: - - "Browser: Edge (latest)" - - "Browser: Chrome (latest)" - - "Browser: Firefox (latest)" - - "Browser: Safari (latest)" - - "Browser: IE Mode (latest)" - - "Platform: Windows" - - "Platform: macOS" - - "Platform: iOS/iPadOS" - - "Platform: Android" + - 'Browser: Edge (latest)' + - 'Browser: Chrome (latest)' + - 'Browser: Firefox (latest)' + - 'Browser: Safari (latest)' + - 'Browser: IE Mode (latest)' + - 'Platform: Windows' + - 'Platform: macOS' + - 'Platform: iOS/iPadOS' + - 'Platform: Android' - Others or unrelated - type: dropdown id: area attributes: label: Which area does this issue affect? options: - - "" - - "Attachment: Adaptive Card" - - "Attachment: OAuth card" - - "Attachment: Other rich cards" + - '' + - 'Attachment: Adaptive Card' + - 'Attachment: OAuth card' + - 'Attachment: Other rich cards' - Chat history - - "Customization: Branding" - - "Customization: Others" + - Citation + - 'Customization: Branding' + - 'Customization: Others' - Development experience - Hooks - Notification @@ -123,7 +124,7 @@ body: attributes: label: What is the public URL for the website? description: If the bot is not intended for public use, please leave this blank. It will be helpful if we can test the bot to understand the issue. - placeholder: https:// + value: https://compulim.github.io/webchat-loader/ - type: textarea id: describe-the-bug attributes: @@ -142,9 +143,7 @@ body: attributes: label: How to reproduce the issue? value: | - 1. Navigate to ... - 2. Click on ... - 3. Type "..." in the send box + 1. Type "..." in the send box validations: required: true - type: textarea diff --git a/CHANGELOG.md b/CHANGELOG.md index 996b513c21..93892d2e7e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixes [#4863](https://github.com/microsoft/BotFramework-WebChat/issues/4863). Disable dark theme for link references until chat history has dark theme support, by [@compulim](https://github.com/compulim), in PR [#4864](https://github.com/microsoft/BotFramework-WebChat/pull/4864) - Fixes [#4866](https://github.com/microsoft/BotFramework-WebChat/issues/4866). Citation modal show fill screen width on mobile device and various fit-and-finish, by [@compulim](https://github.com/compulim), in PR [#4867](https://github.com/microsoft/BotFramework-WebChat/pull/4867) - Fixes [#4878](https://github.com/microsoft/BotFramework-WebChat/issues/4878). `createStore` should return type of `Redux.Store`, by [@compulim](https://github.com/compulim), in PR [#4877](https://github.com/microsoft/BotFramework-WebChat/pull/4877) +- Fixes [#4880](https://github.com/microsoft/BotFramework-WebChat/issues/4880). Originator with long text should be clipped with ellipsis, by [@compulim](https://github.com/compulim), in PR [#4881](https://github.com/microsoft/BotFramework-WebChat/pull/4881) ### Added diff --git a/__tests__/__image_snapshots__/html/provenance-long-js-long-provenance-should-display-and-clipped-1-snap.png b/__tests__/__image_snapshots__/html/provenance-long-js-long-provenance-should-display-and-clipped-1-snap.png new file mode 100644 index 0000000000..5185bb836d Binary files /dev/null and b/__tests__/__image_snapshots__/html/provenance-long-js-long-provenance-should-display-and-clipped-1-snap.png differ diff --git a/__tests__/html/provenance.basic.html b/__tests__/html/provenance.basic.html index 33166e7c7a..ceb7204ceb 100644 --- a/__tests__/html/provenance.basic.html +++ b/__tests__/html/provenance.basic.html @@ -49,6 +49,7 @@ expect(provenanceLink.getAttribute('href')).toBe('https://www.microsoft.com/en-us/ai/responsible-ai'); expect(provenanceLink.getAttribute('rel')).toBe('noopener noreferrer'); expect(provenanceLink.getAttribute('target')).toBe('_blank'); + expect(provenanceLink.getAttribute('title')).toBe('Surfaced by Azure OpenAI'); });
+ + +diff --git a/__tests__/html/provenance.long.html b/__tests__/html/provenance.long.html new file mode 100644 index 0000000000..1c5b01bedf --- /dev/null +++ b/__tests__/html/provenance.long.html @@ -0,0 +1,56 @@ + + +
+ + + + + +
+