Skip to content

Commit 7e943a6

Browse files
changes suggested by copilot
1 parent aec0521 commit 7e943a6

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

docs/DeploymentGuide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ This will rebuild the source code, package it into a container, and push it to t
256256
If you encounter any issues during the deployment process, please refer [troubleshooting](../docs/TroubleShootingSteps.md) document for detailed steps and solutions
257257
258258
## Deploy Your local changes
259-
To Deploy your local changes rename the below files.
259+
To deploy your local changes rename the below files.
260260
1. Rename `azure.yaml` to `azure_custom2.yaml` and `azure_custom.yaml` to `azure.yaml`.
261261
2. Go to `infra` directory
262262
- Rename `main.bicep` to `main_custom2.bicep` and `main_custom.bicep` to `main.bicep`.

infra/main.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,7 @@ module avmStorageAccount 'br/public:avm/res/storage/storage-account:0.20.0' = {
891891
bypass: 'AzureServices'
892892
defaultAction: enablePrivateNetworking ? 'Deny' : 'Allow'
893893
}
894-
allowBlobPublicAccess: enablePrivateNetworking ? true : false
894+
allowBlobPublicAccess: false
895895
publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'
896896
// Private endpoints for blob and queue
897897
privateEndpoints: enablePrivateNetworking

infra/main.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"_generator": {
77
"name": "bicep",
88
"version": "0.37.4.10188",
9-
"templateHash": "17524393707520710386"
9+
"templateHash": "6551365020701659932"
1010
}
1111
},
1212
"parameters": {
@@ -33814,7 +33814,9 @@
3381433814
"defaultAction": "[if(parameters('enablePrivateNetworking'), 'Deny', 'Allow')]"
3381533815
}
3381633816
},
33817-
"allowBlobPublicAccess": "[if(parameters('enablePrivateNetworking'), createObject('value', true()), createObject('value', false()))]",
33817+
"allowBlobPublicAccess": {
33818+
"value": false
33819+
},
3381833820
"publicNetworkAccess": "[if(parameters('enablePrivateNetworking'), createObject('value', 'Disabled'), createObject('value', 'Enabled'))]",
3381933821
"privateEndpoints": "[if(parameters('enablePrivateNetworking'), createObject('value', createArray(createObject('name', format('pep-blob-{0}', variables('solutionSuffix')), 'privateDnsZoneGroup', createObject('privateDnsZoneGroupConfigs', createArray(createObject('name', 'storage-dns-zone-group-blob', 'privateDnsZoneResourceId', reference(format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageBlob)).outputs.resourceId.value))), 'subnetResourceId', reference('virtualNetwork').outputs.pepsSubnetResourceId.value, 'service', 'blob'), createObject('name', format('pep-queue-{0}', variables('solutionSuffix')), 'privateDnsZoneGroup', createObject('privateDnsZoneGroupConfigs', createArray(createObject('name', 'storage-dns-zone-group-queue', 'privateDnsZoneResourceId', reference(format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageQueue)).outputs.resourceId.value))), 'subnetResourceId', reference('virtualNetwork').outputs.pepsSubnetResourceId.value, 'service', 'queue'))), createObject('value', createArray()))]",
3382033822
"blobServices": {

infra/main_custom.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ var solutionLocation = empty(location) ? resourceGroup().location : location
9494
@description('Optional. A unique token for the solution. This is used to ensure resource names are unique for global resources.')
9595
param solutionUniqueToken string = substring(uniqueString(subscription().id, resourceGroup().name, solutionName), 0, 5)
9696

97-
var solutionSuffix= toLower(trim(replace(
97+
var solutionSuffix = toLower(trim(replace(
9898
replace(
9999
replace(replace(replace(replace('${solutionName}${solutionUniqueToken}', '-', ''), '_', ''), '.', ''), '/', ''),
100100
' ',
@@ -782,7 +782,7 @@ module avmStorageAccount 'br/public:avm/res/storage/storage-account:0.20.0' = {
782782
bypass: 'AzureServices'
783783
defaultAction: enablePrivateNetworking ? 'Deny' : 'Allow'
784784
}
785-
allowBlobPublicAccess: enablePrivateNetworking ? true : false
785+
allowBlobPublicAccess: false
786786
publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'
787787
privateEndpoints: enablePrivateNetworking
788788
? [

0 commit comments

Comments
 (0)