fix: merge from dev to main #737
Merged
+70
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note about average response time and formatted the document. Co-authored-by: Prajwal-Microsoft <[email protected]>
Thanusree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a note about average response time to the sample questions documentation. The change informs users that they should expect responses to take between 8-30 seconds when interacting with the Karen Berg client example.
Key Changes
- Added a response time expectation note to the documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* DataRefreshLogic * pylint * pylintfix * fix
…rrect agent handling
fix: reduced the replica instance count to 1 for WAF version
Roopan-Microsoft
approved these changes
Nov 10, 2025
Roopan-Microsoft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the infrastructure deployment templates to use newer API versions and Bicep tooling, and adjusts the server farm capacity configuration for improved stability during WAF deployments. The main changes are grouped below:
Infrastructure API Version Upgrades:
apiVersionfields for Azure resource deployments ininfra/main.jsonfrom2022-09-01to2025-04-01, ensuring compatibility with the latest Azure features and resource types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Bicep Tooling and Template Metadata Updates:
infra/main.jsonto reflect the new version (0.38.33.27573), ensuring template reproducibility and alignment with the latest Bicep features. [1] [2] [3] [4] [5] [6] [7] [8]Server Farm Configuration:
skuCapacityininfra/main.bicepfor web server farms to always be1(instead of3when scalability is enabled), with a comment explaining this avoids multiple agents per type during WAF deployment.Documentation Update:
docs/SampleQuestions.md.Does this introduce a breaking change?
Other Information
Added average response time in Samplequestion.md.