Merged PR 742074: Remove unused experimental Windows container related code

Related work items: #2108981

Author: erikmav

Documentation/Wiki/Flags.md

@@ -201,7 +201,6 @@ This page lists flags that can be used to configure BuildXL.
 | ReuseEngineState | Reuse engine state between client sessions if /server and /cacheGraph are enabled. Defaults to on. |
 | ReuseOutputsOnDisk | Reuse outputs on disk for checking up-to-dateness during cache look-up and for file materialization |
 | RootMap | Specifies a drive mapping applied during this build. Paths under specified letters will be mapped to the corresponding paths at the system level for the build process and the tools launched as a part of the build. (short form: /rm) |
-| RunInContainerAndAllowDoubleWrites | Configures the default for all scheduled pips to run in a container with output isolation, allowing double writes to occur. Individual pips can override this setting. This is an unsafe option. |
 | RunInSubst | Improves path stability across potentially heterogeneous machines by internally mapping a source path (typically the source of the repo to build) into a drive letter. If the source path is not explicitly provided with /substSource, the location of the main config file is used. Only effective on Windows, in other platforms the option is ignored. Useful for dev cache. |
 | SandboxKind | Specifies the sandbox kind. Allowed values are 'None' (no sandboxing), 'Default' (default sandboxing), 'WinDetours', 'MacOsKext'. Default is 'Default'. |
 | ScanChangeJournal | Scans volume change journals to determine spec file changes for graph reuse check. Defaults to on. |

Public/Src/App/Bxl/Args.cs

@@ -2181,11 +2181,6 @@ private void HandleExperimentalOption(
                 case "CREATEHANDLEWITHSEQUENTIALSCANONHASHINGOUTPUTFILES":
                     scheduleConfiguration.CreateHandleWithSequentialScanOnHashingOutputFiles = experimentalOptionAndValue.Item2;
                     break;
-                case "RUNINCONTAINERANDALLOWDOUBLEWRITES":
-                    sandboxConfiguration.ContainerConfiguration.RunInContainer = experimentalOptionAndValue.Item2;
-                    sandboxConfiguration.ContainerConfiguration.ContainerIsolationLevel = ContainerIsolationLevel.IsolateAllOutputs;
-                    sandboxConfiguration.UnsafeSandboxConfigurationMutable.DoubleWritePolicy = RewritePolicy.UnsafeFirstDoubleWriteWins;
-                    break;
                 case "LAZYSODELETION":
                     scheduleConfiguration.UnsafeLazySODeletion = experimentalOptionAndValue.Item2;
                     break;

Public/Src/App/Bxl/HelpText.cs

@@ -1395,7 +1395,6 @@ private static IEnumerable<string> GetExperimentalFlagOptions()
                        "UseGraphPatching",
                        "ConstructAndSaveBindingFingerprint",
                        "UseSpecPublicFacadeAndAstWhenAvailable",
-                       "RunInContainerAndAllowDoubleWrites"
                    };
         }
     }

Public/Src/App/Bxl/Strings.resx

@@ -1000,9 +1000,6 @@ Example: ad2d42d2ec5d2ca0c0b7ad65402d07c7ef40b91e</value>
   <data name="Args_ProfileRedirectEnabled_NoPathProvided" xml:space="preserve">
     <value>User profile redirect was enabled (/enableProfileRedirect+) but the path to the redirected user profile was not set. Please use /RedirectedUserProfileJunctionRoot:&lt;path&gt; to set the path under which a junction to the real user profile will be created.</value>
   </data>
-  <data name="HelpText_DisplayHelp_RunInContainerAndAllowDoubleWrites" xml:space="preserve">
-    <value>Configures the default for all scheduled pips to run in a container with output isolation, allowing double writes to occur. Individual pips can override this setting. This is an unsafe option.</value>
-  </data>
   <data name="HelpText_DisplayHelp_AdminRequiredProcessExecutionMode" xml:space="preserve">
     <value>Mode for running processes that required admin privilege. Allowed values are 'Internal' (BuildXL starts the process as an immediate child process), 'ExternalTool' (BuildXL starts a sandboxed process executor tool as a child process, and in turn the tool starts the admin-required process as its child process), 'ExternalVM' (BuildXL sends command to VM to execute a sandboxed process executor tool in VM, and in turn the tool starts the admin-required process as its child process) . For Internal and ExternalTool, the process will be run with the same elevation level as BuildXL. For ExternalVM, the process will be run with the elevation level in the VM. Defaults to 'Internal'.</value>
   </data>

Public/Src/Cache/ContentStore/DistributedTest/StorageDeploymentIngesterTests.cs

@@ -31,7 +31,6 @@
 using BuildXL.Cache.Host.Service;
 using BuildXL.Cache.Host.Service.Deployment;
 using BuildXL.Launcher.Server;
-using BuildXL.Processes.Containers;
 using BuildXL.Utilities;
 using BuildXL.Utilities.Collections;
 using ContentStoreTest.Distributed.Redis;

Public/Src/Demos/BlockAccesses/BlockingEnumerator.cs

@@ -6,8 +6,6 @@
 using System.IO;
 using System.Threading.Tasks;
 using BuildXL.Processes;
-using BuildXL.Processes.Containers;
-using BuildXL.ProcessPipExecutor;
 using BuildXL.Utilities.Core;
 using BuildXL.Utilities.Instrumentation.Common;
 
@@ -55,7 +53,6 @@ public Task<SandboxedProcessResult> EnumerateWithBlockedDirectories(AbsolutePath
                 pathToProcess,
                 CreateManifest(AbsolutePath.Create(m_pathTable, pathToProcess), directoriesToBlock),
                 disableConHostSharing: false,
-                containerConfiguration: ContainerConfiguration.DisabledIsolation,
                 loggingContext: m_loggingContext)
             {
                 Arguments = arguments,

Public/Src/Demos/ReportAccesses/FileAccessReporter.cs

@@ -5,8 +5,6 @@
 using System.IO;
 using System.Threading.Tasks;
 using BuildXL.Processes;
-using BuildXL.Processes.Containers;
-using BuildXL.ProcessPipExecutor;
 using BuildXL.Utilities.Core;
 using BuildXL.Utilities.Instrumentation.Common;
 
@@ -40,7 +38,6 @@ public Task<SandboxedProcessResult> RunProcessUnderSandbox(string pathToProcess,
                 pathToProcess,
                 CreateManifestToAllowAllAccesses(PathTable),
                 disableConHostSharing: false,
-                containerConfiguration: ContainerConfiguration.DisabledIsolation,
                 loggingContext: m_loggingContext)
             {
                 Arguments = arguments,

Public/Src/Demos/ReportProcesses/ProcessReporter.cs

@@ -4,8 +4,6 @@
 using System.Collections.Generic;
 using System.IO;
 using BuildXL.Processes;
-using BuildXL.Processes.Containers;
-using BuildXL.ProcessPipExecutor;
 using BuildXL.Utilities.Core;
 using BuildXL.Utilities.Instrumentation.Common;
 
@@ -51,7 +49,6 @@ private SandboxedProcessResult RunProcessUnderSandbox(string pathToProcess, stri
                 pathToProcess,
                 CreateManifestToLogProcessData(m_pathTable),
                 disableConHostSharing: false,
-                containerConfiguration: ContainerConfiguration.DisabledIsolation,
                 loggingContext: m_loggingContext)
             {
                 Arguments = arguments,