Merged PR 723148: Make malformed secret error more readable

smera · smera · commit eb239e61fef3 · 2023-06-15T18:37:39.000Z
We used to print:

`Failed to match s_storageUrlRegex to PlainTextSecret`

which users found hard to interpret.
diff --git a/Public/Src/Cache/ContentStore/Interfaces/Secrets/AzureStorageCredentials.cs b/Public/Src/Cache/ContentStore/Interfaces/Secrets/AzureStorageCredentials.cs
@@ -65,7 +65,7 @@ public string GetAccountName()
                         return match.Groups["accountName"].Value;
                     }
 
-                    throw new InvalidOperationException($"Failed to match {nameof(s_storageUrlRegex)} to {nameof(PlainTextSecret)}");
+                    throw new InvalidOperationException($"The provided secret is malformed and the account name could not be retrieved.");
                 case UpdatingSasToken updatingSasToken:
                     return updatingSasToken.Token.StorageAccount;
                 default:

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public string GetAccountName()`
`65`	`65`	`return match.Groups["accountName"].Value;`
`66`	`66`	`}`
`67`	`67`
`68`		`- throw new InvalidOperationException($"Failed to match {nameof(s_storageUrlRegex)} to {nameof(PlainTextSecret)}");`
	`68`	`+ throw new InvalidOperationException($"The provided secret is malformed and the account name could not be retrieved.");`
`69`	`69`	`case UpdatingSasToken updatingSasToken:`
`70`	`70`	`return updatingSasToken.Token.StorageAccount;`
`71`	`71`	`default:`