Merge pull request #234 from microsoft/sfi-code-fix

fix: Code QL issue fixes for usage of DefaultAzureCredential

Author: Prajwal-Microsoft

Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/Services/Queue/AzureStorageQueueService.cs

@@ -84,7 +84,7 @@ public static Uri GetQueueUriFromConnectionString(string connectionString, strin
 
         public AzureStorageQueueService(Uri storageQueueUri, ILogger<AzureStorageQueueService> log)
         {
-            this._clientBuilder = queueName => new QueueClient(storageQueueUri, new DefaultAzureCredential());
+            this._clientBuilder = queueName => new QueueClient(storageQueueUri, new ManagedIdentityCredential());
             this._log = log;
         }
 

Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/Utils/StorageAccessUtil.cs

@@ -16,7 +16,7 @@ static public BlobServiceClient GetBlobClientFromConnectionString(string Connect
             var DefaultEndpointSuffix = "core.windows.net";
             var storageAccountName = ConnectionString.Split(';').FirstOrDefault(x => x.Contains("AccountName")).Split('=')[1];
             var storageAccountUri = new Uri($"https://{storageAccountName}.blob.{DefaultEndpointSuffix}");
-            return new BlobServiceClient(storageAccountUri, new DefaultAzureCredential());
+            return new BlobServiceClient(storageAccountUri, new ManagedIdentityCredential());
         }
 
         static public Stream GetReportResultBlob(string FileName, string ConnectionString)

Services/src/kernel-memory/extensions/AzureAIDocIntel/AzureAIDocIntelEngine.cs

@@ -36,7 +36,7 @@ public AzureAIDocIntelEngine(
         switch (config.Auth)
         {
             case AzureAIDocIntelConfig.AuthTypes.AzureIdentity:
-                this._recognizerClient = new DocumentAnalysisClient(new Uri(config.Endpoint), new DefaultAzureCredential());
+                this._recognizerClient = new DocumentAnalysisClient(new Uri(config.Endpoint), new ManagedIdentityCredential());
                 break;
 
             case AzureAIDocIntelConfig.AuthTypes.APIKey:

Services/src/kernel-memory/extensions/AzureAISearch/AzureAISearch/AzureAISearchMemory.cs

@@ -69,7 +69,7 @@ public AzureAISearchMemory(
             case AzureAISearchConfig.AuthTypes.AzureIdentity:
                 this._adminClient = new SearchIndexClient(
                     new Uri(config.Endpoint),
-                    new DefaultAzureCredential(),
+                    new ManagedIdentityCredential(),
                     GetClientOptions());
                 break;
 

Services/src/kernel-memory/extensions/AzureBlobs/AzureBlobsStorage.cs

@@ -55,7 +55,7 @@ public AzureBlobsStorage(
             {
                 this.ValidateAccountName(config.Account);
                 var suffix = this.ValidateEndpointSuffix(config.EndpointSuffix);
-                client = new BlobServiceClient(new Uri($"https://{config.Account}.blob.{suffix}"), new DefaultAzureCredential());
+                client = new BlobServiceClient(new Uri($"https://{config.Account}.blob.{suffix}"), new ManagedIdentityCredential());
                 break;
             }
 

Services/src/kernel-memory/extensions/AzureOpenAI/AzureOpenAITextEmbeddingGenerator.cs

@@ -75,7 +75,7 @@ public AzureOpenAITextEmbeddingGenerator(
                     deploymentName: config.Deployment,
                     modelId: config.Deployment,
                     endpoint: config.Endpoint,
-                    credential: new DefaultAzureCredential(),
+                    credential: new ManagedIdentityCredential(),
                     httpClient: httpClient);
                 break;
 

Services/src/kernel-memory/extensions/AzureOpenAI/AzureOpenAITextGenerator.cs

@@ -114,7 +114,7 @@ public AzureOpenAITextGenerator(
         switch (config.Auth)
         {
             case AzureOpenAIConfig.AuthTypes.AzureIdentity:
-                this._client = new OpenAIClient(new Uri(config.Endpoint), new DefaultAzureCredential(), options);
+                this._client = new OpenAIClient(new Uri(config.Endpoint), new ManagedIdentityCredential(), options);
                 break;
 
             case AzureOpenAIConfig.AuthTypes.ManualTokenCredential:

Services/src/kernel-memory/extensions/AzureQueues/AzureQueuesPipeline.cs

@@ -102,7 +102,7 @@ public AzureQueuesPipeline(
             {
                 this.ValidateAccountName(config.Account);
                 var suffix = this.ValidateEndpointSuffix(config.EndpointSuffix);
-                this._clientBuilder = queueName => new QueueClient(new($"https://{config.Account}.queue.{suffix}/{queueName}"), new DefaultAzureCredential());
+                this._clientBuilder = queueName => new QueueClient(new($"https://{config.Account}.queue.{suffix}/{queueName}"), new ManagedIdentityCredential());
                 break;
             }