Skip to content

Commit 0dbca00

Browse files
merged with dev
2 parents afee5a7 + fb37ca7 commit 0dbca00

File tree

6 files changed

+74
-121
lines changed

6 files changed

+74
-121
lines changed

infra/deploy_ai_foundry.bicep

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -660,3 +660,4 @@ output aiSearchService string = aiSearch.name
660660
output aiProjectName string = aiHubProject.name
661661

662662
output applicationInsightsId string = applicationInsights.id
663+
output storageAccountName string = storageNameCleaned

infra/deploy_app_service.bicep

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,8 @@ resource Website 'Microsoft.Web/sites@2020-06-01' = {
156156
properties: {
157157
serverFarmId: HostingPlanName
158158
siteConfig: {
159+
alwaysOn: true
160+
ftpsState: 'Disabled'
159161
appSettings: [
160162
{
161163
name: 'APPINSIGHTS_INSTRUMENTATIONKEY'
@@ -226,6 +228,18 @@ resource Website 'Microsoft.Web/sites@2020-06-01' = {
226228
linuxFxVersion: WebAppImageName
227229
}
228230
}
231+
resource basicPublishingCredentialsPoliciesFtp 'basicPublishingCredentialsPolicies' = {
232+
name: 'ftp'
233+
properties: {
234+
allow: false
235+
}
236+
}
237+
resource basicPublishingCredentialsPoliciesScm 'basicPublishingCredentialsPolicies' = {
238+
name: 'scm'
239+
properties: {
240+
allow: false
241+
}
242+
}
229243
dependsOn: [HostingPlan]
230244
}
231245

infra/deploy_azure_function_charts.bicep

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ param sqlDbUser string
88
param sqlDbPwd string
99
// param managedIdentityObjectId string
1010
param imageTag string
11+
param storageAccountName string
1112
var functionAppName = '${solutionName}-charts-fn'
12-
var storageaccountname = '${solutionName}chartfnacc'
1313
var dockerImage = 'DOCKER|kmcontainerreg.azurecr.io/km-charts-function:${imageTag}'
1414
var environmentName = '${solutionName}-charts-fn-env'
1515

@@ -18,19 +18,6 @@ var environmentName = '${solutionName}-charts-fn-env'
1818
// var sqlDbUser = 'sqladmin'
1919
// var sqlDbPwd = 'TestPassword_1234'
2020

21-
resource storageAccount 'Microsoft.Storage/storageAccounts@2023-05-01' = {
22-
name: storageaccountname
23-
location: resourceGroup().location
24-
sku: {
25-
name: 'Standard_LRS'
26-
}
27-
kind: 'StorageV2'
28-
properties: {
29-
accessTier: 'Hot'
30-
allowSharedKeyAccess: false
31-
}
32-
}
33-
3421
resource managedenv 'Microsoft.App/managedEnvironments@2024-03-01' = {
3522
name: environmentName
3623
location: solutionLocation
@@ -69,8 +56,8 @@ resource azurefn 'Microsoft.Web/sites@2023-12-01' = {
6956
siteConfig: {
7057
appSettings: [
7158
{
72-
name: 'AzureWebJobsStorage'
73-
value: 'DefaultEndpointsProtocol=https;AccountName=${storageAccount};EndpointSuffix=core.windows.net'
59+
name: 'AzureWebJobsStorage__accountname'
60+
value: storageAccountName
7461
}
7562
{
7663
name: 'SQLDB_DATABASE'
@@ -104,13 +91,4 @@ resource azurefn 'Microsoft.Web/sites@2023-12-01' = {
10491
}
10592
}
10693

107-
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
108-
name: guid(subscription().id, resourceGroup().id, azurefn.id, 'StorageBlobDataContributor')
109-
scope: storageAccount
110-
properties: {
111-
roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'ba92f5b4-2d11-453d-a403-e96b0029c9fe') // Storage Blob Data Contributor
112-
principalId: azurefn.identity.principalId
113-
}
114-
}
115-
11694

infra/deploy_azure_function_rag.bicep

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ param sqlDbUser string
2020
param sqlDbPwd string
2121
// param managedIdentityObjectId string
2222
param imageTag string
23+
param storageAccountName string
2324
var functionAppName = '${solutionName}-rag-fn'
24-
var storageaccountname = '${solutionName}ragfnacc'
2525
var dockerImage = 'DOCKER|kmcontainerreg.azurecr.io/km-rag-function:${imageTag}'
2626
var environmentName = '${solutionName}-rag-fn-env'
2727

@@ -30,19 +30,6 @@ var environmentName = '${solutionName}-rag-fn-env'
3030
// var sqlDbUser = 'sqladmin'
3131
// var sqlDbPwd = 'TestPassword_1234'
3232

33-
resource storageAccount 'Microsoft.Storage/storageAccounts@2023-05-01' = {
34-
name: storageaccountname
35-
location: resourceGroup().location
36-
sku: {
37-
name: 'Standard_LRS'
38-
}
39-
kind: 'StorageV2'
40-
properties: {
41-
accessTier: 'Hot'
42-
allowSharedKeyAccess: false
43-
}
44-
}
45-
4633
resource managedenv 'Microsoft.App/managedEnvironments@2024-03-01' = {
4734
name: environmentName
4835
location: solutionLocation
@@ -81,8 +68,8 @@ resource azurefn 'Microsoft.Web/sites@2023-12-01' = {
8168
siteConfig: {
8269
appSettings: [
8370
{
84-
name: 'AzureWebJobsStorage'
85-
value: 'DefaultEndpointsProtocol=https;AccountName=${storageAccount};EndpointSuffix=core.windows.net'
71+
name: 'AzureWebJobsStorage__accountname'
72+
value: storageAccountName
8673
}
8774
{
8875
name: 'PYTHON_ENABLE_INIT_INDEXING'
@@ -155,15 +142,6 @@ resource azurefn 'Microsoft.Web/sites@2023-12-01' = {
155142
}
156143
}
157144

158-
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
159-
name: guid(subscription().id, resourceGroup().id, azurefn.id, 'StorageBlobDataContributor')
160-
scope: storageAccount
161-
properties: {
162-
roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'ba92f5b4-2d11-453d-a403-e96b0029c9fe') // Storage Blob Data Contributor
163-
principalId: azurefn.identity.principalId
164-
}
165-
}
166-
167145
resource aiHubProject 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' existing = {
168146
name: aiProjectName
169147
}

infra/main.bicep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ module azureFunctionsCharts 'deploy_azure_function_charts.bicep' = {
192192
sqlDbUser: sqlDBModule.outputs.sqlDbUser
193193
sqlDbPwd:keyVault.getSecret('SQLDB-PASSWORD')
194194
// managedIdentityObjectId:managedIdentityModule.outputs.managedIdentityOutput.objectId
195+
storageAccountName:aifoundry.outputs.storageAccountName
195196
}
196197
dependsOn:[keyVault]
197198
}
@@ -217,6 +218,7 @@ module azureragFunctionsRag 'deploy_azure_function_rag.bicep' = {
217218
sqlDbPwd:keyVault.getSecret('SQLDB-PASSWORD')
218219
aiProjectName:aifoundry.outputs.aiProjectName
219220
// managedIdentityObjectId:managedIdentityModule.outputs.managedIdentityOutput.objectId
221+
storageAccountName:aifoundry.outputs.storageAccountName
220222
}
221223
dependsOn:[keyVault]
222224
}

0 commit comments

Comments
 (0)