fix: Kernel Function Method Renaming for Clarity

Author: Avijit-Microsoft

src/api/plugins/chat_with_data_plugin.py

@@ -36,9 +36,9 @@ def __init__(self):
         self.azure_ai_search_index = config.azure_ai_search_index
         self.use_ai_project_client = config.use_ai_project_client
 
-    @kernel_function(name="ChatWithSQLDatabase",
+    @kernel_function(name="GetDatabaseMetrics",
                      description="Provides quantified results from the database.")
-    async def get_sql_response(
+    async def get_database_metrics(
             self,
             input: Annotated[str, "the question"]
     ):
@@ -94,8 +94,8 @@ async def get_sql_response(
 
         return answer
 
-    @kernel_function(name="ChatWithCallTranscripts", description="Provides summaries or detailed explanations from the search index.")
-    async def get_answers_from_calltranscripts(
+    @kernel_function(name="GetCallInsights", description="Provides summaries, explanations, and insights from customer call transcripts.")
+    async def get_call_insights(
             self,
             question: Annotated[str, "the question"]
     ):
@@ -168,13 +168,12 @@ def replace_marker(match):
         return answer
 
     @kernel_function(name="GenerateChartData", description="Generates Chart.js v4.4.4 compatible JSON data for data visualization requests using current and immediate previous context.")
-    async def get_chart_data(
+    async def generate_chart_data(
             self,
             input: Annotated[str, "The user's data visualization request along with relevant conversation history and context needed to generate appropriate chart data"],
     ):
         query = input
         query = query.strip()
-        print("Query for chart data:", query, flush=True)
         try:
             agent_info = await ChartAgentFactory.get_agent()
             agent = agent_info["agent"]
@@ -208,5 +207,4 @@ async def get_chart_data(
 
         except Exception:
             chartdata = 'Details could not be retrieved. Please try again later.'
-        print("Chart data:", chartdata, flush=True)
         return chartdata

src/tests/api/plugins/test_chat_with_data_plugin.py

@@ -29,7 +29,7 @@ class TestChatWithDataPlugin:
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.execute_sql_query", new_callable=AsyncMock)
     @patch("plugins.chat_with_data_plugin.SQLAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_sql_response_with_sql_agent(self, mock_get_agent, mock_execute_sql, chat_plugin):
+    async def test_get_database_metrics_with_sql_agent(self, mock_get_agent, mock_execute_sql, chat_plugin):
         # Mocks
         mock_agent = MagicMock()
         mock_agent.id = "agent-id"
@@ -63,7 +63,7 @@ async def test_get_sql_response_with_sql_agent(self, mock_get_agent, mock_execut
         mock_client.agents.threads.delete.return_value = None
 
         # Act
-        result = await chat_plugin.get_sql_response("Total number of calls by date for last 7 days")
+        result = await chat_plugin.get_database_metrics("Total number of calls by date for last 7 days")
 
         # Assert
         assert result == "(datetime.date(2025, 6, 27), 11)(datetime.date(2025, 6, 28), 20)(datetime.date(2025, 6, 29), 29)(datetime.date(2025, 6, 30), 17)(datetime.date(2025, 7, 1), 19)(datetime.date(2025, 7, 2), 16)"
@@ -77,12 +77,12 @@ async def test_get_sql_response_with_sql_agent(self, mock_get_agent, mock_execut
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.execute_sql_query")
     @patch("plugins.chat_with_data_plugin.SQLAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_sql_response_exception(self, mock_get_agent, mock_execute_sql, chat_plugin):
+    async def test_get_database_metrics_exception(self, mock_get_agent, mock_execute_sql, chat_plugin):
         # Setup mock to raise exception
         mock_get_agent.side_effect = Exception("Test error")
 
         # Call the method
-        result = await chat_plugin.get_sql_response("Show me data")
+        result = await chat_plugin.get_database_metrics("Show me data")
 
         # Assertions
         assert result == "Details could not be retrieved. Please try again later."
@@ -91,7 +91,7 @@ async def test_get_sql_response_exception(self, mock_get_agent, mock_execute_sql
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.SearchAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_answers_from_calltranscripts_success(self, mock_get_agent, chat_plugin):
+    async def test_get_call_insights_success(self, mock_get_agent, chat_plugin):
         # Use the fixture passed by pytest
         self.chat_plugin = chat_plugin  # or just use `chat_plugin` directly
 
@@ -138,7 +138,7 @@ async def test_get_answers_from_calltranscripts_success(self, mock_get_agent, ch
         mock_client.agents.threads.delete.return_value = None
 
         # Call the method
-        result = await chat_plugin.get_answers_from_calltranscripts("What is the summary?")
+        result = await chat_plugin.get_call_insights("What is the summary?")
 
         # Assert
         assert isinstance(result, dict)
@@ -147,19 +147,19 @@ async def test_get_answers_from_calltranscripts_success(self, mock_get_agent, ch
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.SearchAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_answers_from_calltranscripts_exception(self, mock_get_agent, chat_plugin):
+    async def test_get_call_insights_exception(self, mock_get_agent, chat_plugin):
         # Setup the mock to raise an exception
         mock_get_agent.side_effect = Exception("Test error")
 
         # Call the method
-        result = await chat_plugin.get_answers_from_calltranscripts("Sample question")
+        result = await chat_plugin.get_call_insights("Sample question")
 
         # Assertions
         assert result == "Details could not be retrieved. Please try again later."
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.ChartAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_chart_data_success(self, mock_get_agent, chat_plugin):
+    async def test_generate_chart_data_success(self, mock_get_agent, chat_plugin):
         # Mock agent and client setup
         mock_agent = MagicMock()
         mock_agent.id = "chart-agent-id"
@@ -187,7 +187,7 @@ async def test_get_chart_data_success(self, mock_get_agent, chat_plugin):
         mock_client.agents.threads.delete.return_value = None
 
         # Call the method with combined input
-        result = await chat_plugin.get_chart_data(
+        result = await chat_plugin.generate_chart_data(
             "Create a bar chart. Total calls by date: 2025-06-27: 11, 2025-06-28: 20"
         )
 
@@ -208,7 +208,7 @@ async def test_get_chart_data_success(self, mock_get_agent, chat_plugin):
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.ChartAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_chart_data_failed_run(self, mock_get_agent, chat_plugin):
+    async def test_generate_chart_data_failed_run(self, mock_get_agent, chat_plugin):
         # Mock agent and client setup
         mock_agent = MagicMock()
         mock_agent.id = "chart-agent-id"
@@ -227,7 +227,7 @@ async def test_get_chart_data_failed_run(self, mock_get_agent, chat_plugin):
         mock_client.agents.runs.create_and_process.return_value = mock_run
 
         # Call the method with single input parameter
-        result = await chat_plugin.get_chart_data("Create a chart with some data")
+        result = await chat_plugin.generate_chart_data("Create a chart with some data")
 
         # Assert
         assert result == "Details could not be retrieved. Please try again later."
@@ -240,19 +240,19 @@ async def test_get_chart_data_failed_run(self, mock_get_agent, chat_plugin):
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.ChartAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_chart_data_exception(self, mock_get_agent, chat_plugin):
+    async def test_generate_chart_data_exception(self, mock_get_agent, chat_plugin):
         # Setup mock to raise exception
         mock_get_agent.side_effect = Exception("Chart agent error")
 
         # Call the method with single input parameter
-        result = await chat_plugin.get_chart_data("Create a chart with some data")
+        result = await chat_plugin.generate_chart_data("Create a chart with some data")
 
         # Assert
         assert result == "Details could not be retrieved. Please try again later."
 
     @pytest.mark.asyncio
     @patch("plugins.chat_with_data_plugin.ChartAgentFactory.get_agent", new_callable=AsyncMock)
-    async def test_get_chart_data_empty_response(self, mock_get_agent, chat_plugin):
+    async def test_generate_chart_data_empty_response(self, mock_get_agent, chat_plugin):
         # Mock agent and client setup
         mock_agent = MagicMock()
         mock_agent.id = "chart-agent-id"
@@ -276,7 +276,7 @@ async def test_get_chart_data_empty_response(self, mock_get_agent, chat_plugin):
         mock_client.agents.threads.delete.return_value = None
 
         # Call the method with single input parameter
-        result = await chat_plugin.get_chart_data("Create a chart with some data")
+        result = await chat_plugin.generate_chart_data("Create a chart with some data")
 
         # Assert - should return empty string when no agent messages found
         assert result == ""