refactor: remove complete_chat_request method and related tests from ChatService and TestChatService

Author: Pavan-Microsoft

src/api/services/chat_service.py

@@ -180,27 +180,3 @@ async def generate():
                 yield json.dumps({"error": "An error occurred while processing the request."}) + "\n\n"
 
         return generate()
-
-    async def complete_chat_request(self, query, last_rag_response=None):
-        """
-        Completes a chat request by generating a chart from the RAG response.
-        """
-        if not last_rag_response:
-            return {"error": "A previous RAG response is required to generate a chart."}
-
-        # Process RAG response to generate chart data
-        chart_data = await self.process_rag_response(last_rag_response, query)
-
-        if not chart_data or "error" in chart_data:
-            return {
-                "error": "Chart could not be generated from this data. Please ask a different question.",
-                "error_desc": str(chart_data),
-            }
-
-        logger.info("Successfully generated chart data.")
-        return {
-            "id": str(uuid.uuid4()),
-            "model": "azure-openai",
-            "created": int(time.time()),
-            "object": chart_data,
-        }

src/tests/api/services/test_chat_service.py

@@ -5,7 +5,6 @@
 import pytest
 from fastapi import HTTPException, status
 from semantic_kernel.exceptions.agent_exceptions import AgentException as RealAgentException
-from azure.ai.agents.models import MessageRole
 
 
 
@@ -244,16 +243,8 @@ async def mock_invoke_stream(*args, **kwargs):
         assert "I cannot answer this question with the current data" in chunks[0]
 
     @pytest.mark.asyncio
-    @patch('services.chat_service.uuid.uuid4')
-    @patch('services.chat_service.time.time')
-    @patch('services.chat_service.format_stream_response')
-    async def test_stream_chat_request_success(self, mock_format_stream, mock_time, mock_uuid, chat_service):
+    async def test_stream_chat_request_success(self, chat_service):
         """Test successful stream chat request."""
-        # Setup mocks
-        mock_uuid.return_value = "test-uuid"
-        mock_time.return_value = 1234567890
-        mock_format_stream.return_value = {"formatted": "response"}
-        
         # Mock stream_openai_text
         async def mock_stream_openai_text(conversation_id, query):
             yield "Hello"
@@ -272,7 +263,11 @@ async def mock_stream_openai_text(conversation_id, query):
         # Verify the chunks contain expected structure
         for chunk in chunks:
             chunk_data = json.loads(chunk.strip())
-            assert "formatted" in chunk_data
+            assert "choices" in chunk_data
+            assert len(chunk_data["choices"]) > 0
+            assert "messages" in chunk_data["choices"][0]
+            assert len(chunk_data["choices"][0]["messages"]) > 0
+            assert chunk_data["choices"][0]["messages"][0]["role"] == "assistant"
 
     @pytest.mark.asyncio
     async def test_stream_chat_request_agent_exception_rate_limit(self, chat_service):
@@ -345,46 +340,4 @@ async def mock_stream_openai_text_generic_error(conversation_id, query):
         error_data = json.loads(chunks[0].strip())
         assert "error" in error_data
         assert "An error occurred while processing the request." == error_data["error"]
-    
-    @pytest.mark.asyncio
-    async def test_complete_chat_request_success(self, chat_service):
-        mock_chart_data = {
-            "type": "bar",
-            "data": {
-             "labels": ["A"],
-             "datasets": [{"data": [1]}]
-            }
-        }
-
-        chat_service.process_rag_response = AsyncMock(return_value=mock_chart_data)
-
-        result = await chat_service.complete_chat_request("Query", last_rag_response="RAG response")
-
-        assert result["object"]["type"] == "bar"
-
-    
-    @pytest.mark.asyncio
-    async def test_complete_chat_request_no_rag_response(self, chat_service):
-        """Test complete chat request without RAG response."""
-        result = await chat_service.complete_chat_request("Query", last_rag_response=None)
-        
-        assert "error" in result
-        assert result["error"] == "A previous RAG response is required to generate a chart."
-    
-    @pytest.mark.asyncio
-    async def test_complete_chat_request_chart_error(self, chat_service):
-        chat_service.process_rag_response = AsyncMock(return_value={"error": "Chart generation failed"})
-
-        result = await chat_service.complete_chat_request("Query", last_rag_response="RAG response")
-
-        assert "error" in result
-
-    
-    @pytest.mark.asyncio
-    async def test_complete_chat_request_empty_chart_data(self, chat_service):
-        chat_service.process_rag_response = AsyncMock(return_value=None)
-
-        result = await chat_service.complete_chat_request("Query", last_rag_response="RAG response")
-
-        assert "error" in result
 

src/tests/api/services/test_history_service.py

@@ -30,9 +30,8 @@ def history_service(mock_config_instance):
     with patch("services.history_service.Config", return_value=mock_config_instance):
         # Create patches for other dependencies used by HistoryService
         with patch("services.history_service.CosmosConversationClient"):
-            with patch("services.history_service.complete_chat_request"):
-                service = HistoryService()
-                return service
+            service = HistoryService()
+            return service
 
 
 @pytest.fixture