Skip to content

Commit f43acff

Browse files
Merge pull request #678 from microsoft/revert-675-pipeline-fix
ci: improved pipeline for deployment
2 parents f2e29ac + 8555e6c commit f43acff

File tree

4 files changed

+17
-21
lines changed

4 files changed

+17
-21
lines changed

.github/workflows/deploy-linux.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,17 @@ on:
88
azure_location:
99
description: 'Azure Location For Deployment'
1010
required: false
11-
default: 'none'
11+
default: 'australiaeast'
1212
type: choice
1313
options:
14-
- 'none'
1514
- 'australiaeast'
16-
- 'eastus'
15+
- 'centralus'
16+
- 'eastasia'
1717
- 'eastus2'
18-
- 'francecentral'
1918
- 'japaneast'
20-
- 'swedencentral'
19+
- 'northeurope'
20+
- 'southeastasia'
2121
- 'uksouth'
22-
- 'westus'
23-
- 'westus3'
2422
resource_group_name:
2523
description: 'Resource Group Name (Optional)'
2624
required: false
@@ -76,7 +74,7 @@ jobs:
7674
uses: ./.github/workflows/deploy-orchestrator.yml
7775
with:
7876
runner_os: ubuntu-latest
79-
azure_location: ${{ github.event.inputs.azure_location }}
77+
azure_location: ${{ github.event.inputs.azure_location || 'australiaeast' }}
8078
resource_group_name: ${{ github.event.inputs.resource_group_name || '' }}
8179
waf_enabled: ${{ github.event.inputs.waf_enabled == 'true' }}
8280
exp: ${{ github.event.inputs.exp == 'true' }}

.github/workflows/deploy-orchestrator.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
azure_location:
1111
description: 'Azure Location For Deployment'
1212
required: false
13-
default: ''
13+
default: 'australiaeast'
1414
type: string
1515
resource_group_name:
1616
description: 'Resource Group Name (Optional)'

.github/workflows/deploy-windows.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,17 @@ on:
88
azure_location:
99
description: 'Azure Location For Deployment'
1010
required: false
11-
default: 'none'
11+
default: 'australiaeast'
1212
type: choice
1313
options:
14-
- 'none'
1514
- 'australiaeast'
16-
- 'eastus'
15+
- 'centralus'
16+
- 'eastasia'
1717
- 'eastus2'
18-
- 'francecentral'
1918
- 'japaneast'
20-
- 'swedencentral'
19+
- 'northeurope'
20+
- 'southeastasia'
2121
- 'uksouth'
22-
- 'westus'
23-
- 'westus3'
2422
resource_group_name:
2523
description: 'Resource Group Name (Optional)'
2624
required: false
@@ -76,7 +74,7 @@ jobs:
7674
uses: ./.github/workflows/deploy-orchestrator.yml
7775
with:
7876
runner_os: windows-latest
79-
azure_location: ${{ github.event.inputs.azure_location }}
77+
azure_location: ${{ github.event.inputs.azure_location || 'australiaeast' }}
8078
resource_group_name: ${{ github.event.inputs.resource_group_name || '' }}
8179
waf_enabled: ${{ github.event.inputs.waf_enabled == 'true' }}
8280
exp: ${{ github.event.inputs.exp == 'true' }}

.github/workflows/job-azure-deploy.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
azure_location:
1515
description: 'Azure Location For Deployment'
1616
required: false
17-
default: ''
17+
default: 'australiaeast'
1818
type: string
1919
resource_group_name:
2020
description: 'Resource Group Name (Optional)'
@@ -159,7 +159,7 @@ jobs:
159159
export AZURE_SUBSCRIPTION_ID="${{ secrets.AZURE_SUBSCRIPTION_ID }}"
160160
export GPT_MIN_CAPACITY=${{ env.GPT_MIN_CAPACITY }}
161161
export TEXT_EMBEDDING_MIN_CAPACITY=${{ env.TEXT_EMBEDDING_MIN_CAPACITY }}
162-
export AZURE_REGIONS="${{ inputs.azure_location || vars.AZURE_REGIONS }}"
162+
export AZURE_REGIONS="${{ vars.AZURE_REGIONS }}"
163163
164164
chmod +x infra/scripts/checkquota_km.sh
165165
if ! infra/scripts/checkquota_km.sh; then
@@ -185,7 +185,7 @@ jobs:
185185
echo "AZURE_ENV_OPENAI_LOCATION=$VALID_REGION" >> $GITHUB_ENV
186186
echo "AZURE_ENV_OPENAI_LOCATION=$VALID_REGION" >> $GITHUB_OUTPUT
187187
188-
if [[ "${{ inputs.trigger_type }}" == "workflow_dispatch" && -n "${{ inputs.azure_location }}" && "${{ inputs.azure_location }}" != "none" ]]; then
188+
if [[ "${{ inputs.trigger_type }}" == "workflow_dispatch" && -n "${{ inputs.azure_location }}" ]]; then
189189
USER_SELECTED_LOCATION="${{ inputs.azure_location }}"
190190
echo "Using user-selected Azure location: $USER_SELECTED_LOCATION"
191191
echo "AZURE_LOCATION=$USER_SELECTED_LOCATION" >> $GITHUB_ENV
@@ -311,7 +311,7 @@ jobs:
311311
echo "| **Cleanup Resources** | ${{ env.CLEANUP_RESOURCES == 'true' && '✅ Yes' || '❌ No' }} |" >> $GITHUB_STEP_SUMMARY
312312
echo "| **Build Docker Image** | ${{ env.BUILD_DOCKER_IMAGE == 'true' && '✅ Yes' || '❌ No' }} |" >> $GITHUB_STEP_SUMMARY
313313
314-
if [[ "${{ inputs.trigger_type }}" == "workflow_dispatch" && -n "${{ inputs.azure_location }}" && "${{ inputs.azure_location }}" != "none" ]]; then
314+
if [[ "${{ inputs.trigger_type }}" == "workflow_dispatch" && -n "${{ inputs.azure_location }}" ]]; then
315315
echo "| **Azure Location** | \`${{ inputs.azure_location }}\` (User Selected) |" >> $GITHUB_STEP_SUMMARY
316316
fi
317317

0 commit comments

Comments
 (0)