Skip to content

Commit e75c0d9

Browse files
authored
Ignore bot PR reviews (#1204)
1 parent 7f7cae5 commit e75c0d9

File tree

7 files changed

+386
-0
lines changed

7 files changed

+386
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"webxr": 5794110
3+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"bc685e16eb9e0c33df331e571993dd814aea9e20:types/webxr/package.json": "{\n \"private\": true,\n \"name\": \"@types/webxr\",\n \"version\": \"0.5.9999\",\n \"nonNpm\": \"conflict\",\n \"nonNpmDescription\": \"webxr\",\n \"projects\": [\n \"https://www.w3.org/TR/webxr/\"\n ],\n \"devDependencies\": {\n \"@types/webxr\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"Rob Rohan\",\n \"githubUsername\": \"robrohan\"\n },\n {\n \"name\": \"Raanan Weber\",\n \"githubUsername\": \"RaananW\"\n },\n {\n \"name\": \"Sean T. McBeth\",\n \"githubUsername\": \"capnmidnight\"\n },\n {\n \"name\": \"Timmy Kokke\",\n \"githubUsername\": \"sorskoot\"\n }\n ]\n}\n",
3+
"d95f839e8f8a345c37ebd7b242447c8fa4d1971b:types/webxr/package.json": "{\n \"private\": true,\n \"name\": \"@types/webxr\",\n \"version\": \"0.5.9999\",\n \"nonNpm\": \"conflict\",\n \"nonNpmDescription\": \"webxr\",\n \"projects\": [\n \"https://www.w3.org/TR/webxr/\"\n ],\n \"devDependencies\": {\n \"@types/webxr\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"Rob Rohan\",\n \"githubUsername\": \"robrohan\"\n },\n {\n \"name\": \"Raanan Weber\",\n \"githubUsername\": \"RaananW\"\n },\n {\n \"name\": \"Sean T. McBeth\",\n \"githubUsername\": \"capnmidnight\"\n },\n {\n \"name\": \"Timmy Kokke\",\n \"githubUsername\": \"sorskoot\"\n }\n ]\n}\n"
4+
}
Lines changed: 303 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,303 @@
1+
{
2+
"data": {
3+
"repository": {
4+
"id": "MDEwOlJlcG9zaXRvcnk2MDkzMzE2",
5+
"pullRequest": {
6+
"id": "PR_kwDOAFz6BM6quEpg",
7+
"title": "[WebXR] Enhance XRAnchor and XRSession with persistent anchor support",
8+
"createdAt": "2025-09-26T13:21:09Z",
9+
"author": {
10+
"login": "sorskoot",
11+
"__typename": "User"
12+
},
13+
"authorAssociation": "CONTRIBUTOR",
14+
"baseRef": {
15+
"name": "master",
16+
"__typename": "Ref"
17+
},
18+
"labels": {
19+
"nodes": [
20+
{
21+
"name": "Author is Owner",
22+
"__typename": "Label"
23+
},
24+
{
25+
"name": "Critical package",
26+
"__typename": "Label"
27+
}
28+
],
29+
"__typename": "LabelConnection"
30+
},
31+
"isDraft": false,
32+
"mergeable": "MERGEABLE",
33+
"number": 73752,
34+
"state": "OPEN",
35+
"headRefOid": "d95f839e8f8a345c37ebd7b242447c8fa4d1971b",
36+
"changedFiles": 2,
37+
"additions": 115,
38+
"deletions": 5,
39+
"commitIds": {
40+
"nodes": [
41+
{
42+
"commit": {
43+
"oid": "5169abe781ebb8d80e3e247cfd46b9481cd6142b",
44+
"parents": {
45+
"nodes": [
46+
{
47+
"oid": "bc685e16eb9e0c33df331e571993dd814aea9e20",
48+
"__typename": "Commit"
49+
}
50+
],
51+
"__typename": "CommitConnection"
52+
},
53+
"__typename": "Commit"
54+
},
55+
"__typename": "PullRequestCommit"
56+
},
57+
{
58+
"commit": {
59+
"oid": "024f18e88aa3d2a9e40a50b798a778dd9cc43358",
60+
"parents": {
61+
"nodes": [
62+
{
63+
"oid": "5169abe781ebb8d80e3e247cfd46b9481cd6142b",
64+
"__typename": "Commit"
65+
}
66+
],
67+
"__typename": "CommitConnection"
68+
},
69+
"__typename": "Commit"
70+
},
71+
"__typename": "PullRequestCommit"
72+
},
73+
{
74+
"commit": {
75+
"oid": "d95f839e8f8a345c37ebd7b242447c8fa4d1971b",
76+
"parents": {
77+
"nodes": [
78+
{
79+
"oid": "024f18e88aa3d2a9e40a50b798a778dd9cc43358",
80+
"__typename": "Commit"
81+
}
82+
],
83+
"__typename": "CommitConnection"
84+
},
85+
"__typename": "Commit"
86+
},
87+
"__typename": "PullRequestCommit"
88+
}
89+
],
90+
"__typename": "PullRequestCommitConnection"
91+
},
92+
"timelineItems": {
93+
"nodes": [],
94+
"__typename": "PullRequestTimelineItemsConnection"
95+
},
96+
"reviews": {
97+
"nodes": [
98+
{
99+
"author": {
100+
"login": "copilot-pull-request-reviewer",
101+
"__typename": "Bot"
102+
},
103+
"commit": {
104+
"oid": "5169abe781ebb8d80e3e247cfd46b9481cd6142b",
105+
"__typename": "Commit"
106+
},
107+
"comments": {
108+
"nodes": [
109+
{
110+
"author": {
111+
"login": "copilot-pull-request-reviewer",
112+
"__typename": "Bot"
113+
},
114+
"createdAt": "2025-09-26T13:21:44Z",
115+
"__typename": "PullRequestReviewComment"
116+
},
117+
{
118+
"author": {
119+
"login": "copilot-pull-request-reviewer",
120+
"__typename": "Bot"
121+
},
122+
"createdAt": "2025-09-26T13:21:44Z",
123+
"__typename": "PullRequestReviewComment"
124+
},
125+
{
126+
"author": {
127+
"login": "copilot-pull-request-reviewer",
128+
"__typename": "Bot"
129+
},
130+
"createdAt": "2025-09-26T13:21:45Z",
131+
"__typename": "PullRequestReviewComment"
132+
}
133+
],
134+
"__typename": "PullRequestReviewCommentConnection"
135+
},
136+
"authorAssociation": "CONTRIBUTOR",
137+
"state": "COMMENTED",
138+
"submittedAt": "2025-09-26T13:21:45Z",
139+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/73752#pullrequestreview-3272265809",
140+
"__typename": "PullRequestReview"
141+
}
142+
],
143+
"__typename": "PullRequestReviewConnection"
144+
},
145+
"commits": {
146+
"totalCount": 3,
147+
"nodes": [
148+
{
149+
"commit": {
150+
"checkSuites": {
151+
"nodes": [
152+
{
153+
"databaseId": 46363170399,
154+
"app": {
155+
"name": "GitHub Actions",
156+
"__typename": "App"
157+
},
158+
"conclusion": "SUCCESS",
159+
"resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/d95f839e8f8a345c37ebd7b242447c8fa4d1971b/checks?check_suite_id=46363170399",
160+
"status": "COMPLETED",
161+
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/d95f839e8f8a345c37ebd7b242447c8fa4d1971b/checks?check_suite_id=46363170399",
162+
"checkRuns": {
163+
"nodes": [
164+
{
165+
"title": null,
166+
"__typename": "CheckRun"
167+
}
168+
],
169+
"__typename": "CheckRunConnection"
170+
},
171+
"createdAt": "2025-09-26T13:37:54Z",
172+
"workflowRun": {
173+
"file": {
174+
"path": ".github/workflows/CI.yml",
175+
"__typename": "WorkflowRunFile"
176+
},
177+
"__typename": "WorkflowRun"
178+
},
179+
"__typename": "CheckSuite"
180+
}
181+
],
182+
"__typename": "CheckSuiteConnection"
183+
},
184+
"status": null,
185+
"authoredDate": "2025-09-26T13:37:47Z",
186+
"committedDate": "2025-09-26T13:37:47Z",
187+
"pushedDate": null,
188+
"oid": "d95f839e8f8a345c37ebd7b242447c8fa4d1971b",
189+
"__typename": "Commit"
190+
},
191+
"__typename": "PullRequestCommit"
192+
}
193+
],
194+
"__typename": "PullRequestCommitConnection"
195+
},
196+
"comments": {
197+
"totalCount": 3,
198+
"nodes": [
199+
{
200+
"id": "IC_kwDOAFz6BM7HALVM",
201+
"author": {
202+
"login": "typescript-bot",
203+
"__typename": "User"
204+
},
205+
"authorAssociation": "MEMBER",
206+
"databaseId": 3338712396,
207+
"body": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->",
208+
"createdAt": "2025-09-26T13:22:24Z",
209+
"reactions": {
210+
"nodes": [],
211+
"__typename": "ReactionConnection"
212+
},
213+
"__typename": "IssueComment"
214+
},
215+
{
216+
"id": "IC_kwDOAFz6BM7HALXa",
217+
"author": {
218+
"login": "typescript-bot",
219+
"__typename": "User"
220+
},
221+
"authorAssociation": "MEMBER",
222+
"databaseId": 3338712538,
223+
"body": "🔔 @robrohan @RaananW @capnmidnight — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/73752/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on.\n<!--typescript_bot_pinging-reviewers-->",
224+
"createdAt": "2025-09-26T13:22:26Z",
225+
"reactions": {
226+
"nodes": [],
227+
"__typename": "ReactionConnection"
228+
},
229+
"__typename": "IssueComment"
230+
},
231+
{
232+
"id": "IC_kwDOAFz6BM7HATkL",
233+
"author": {
234+
"login": "typescript-bot",
235+
"__typename": "User"
236+
},
237+
"authorAssociation": "MEMBER",
238+
"databaseId": 3338746123,
239+
"body": "@copilot-pull-request-reviewer Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-6d0325-5169abe-->",
240+
"createdAt": "2025-09-26T13:31:08Z",
241+
"reactions": {
242+
"nodes": [],
243+
"__typename": "ReactionConnection"
244+
},
245+
"__typename": "IssueComment"
246+
}
247+
],
248+
"__typename": "IssueCommentConnection"
249+
},
250+
"files": {
251+
"totalCount": 2,
252+
"nodes": [
253+
{
254+
"path": "types/webxr/index.d.ts",
255+
"additions": 74,
256+
"deletions": 5,
257+
"__typename": "PullRequestChangedFile"
258+
},
259+
{
260+
"path": "types/webxr/webxr-tests.ts",
261+
"additions": 41,
262+
"deletions": 0,
263+
"__typename": "PullRequestChangedFile"
264+
}
265+
],
266+
"pageInfo": {
267+
"hasNextPage": false,
268+
"endCursor": "Mg",
269+
"__typename": "PageInfo"
270+
},
271+
"__typename": "PullRequestChangedFileConnection"
272+
},
273+
"projectItems": {
274+
"nodes": [
275+
{
276+
"id": "PVTI_lADOADeBNM4AkH1qzgfNJNw",
277+
"project": {
278+
"id": "PVT_kwDOADeBNM4AkH1q",
279+
"number": 1,
280+
"__typename": "ProjectV2"
281+
},
282+
"fieldValueByName": {
283+
"name": "Needs Maintainer Review",
284+
"field": {
285+
"id": "PVTSSF_lADOADeBNM4AkH1qzgcYOEM",
286+
"__typename": "ProjectV2SingleSelectField"
287+
},
288+
"__typename": "ProjectV2ItemFieldSingleSelectValue"
289+
},
290+
"updatedAt": "2025-09-26T13:44:04Z",
291+
"__typename": "ProjectV2Item"
292+
}
293+
],
294+
"__typename": "ProjectV2ItemConnection"
295+
},
296+
"__typename": "PullRequest"
297+
},
298+
"__typename": "Repository"
299+
}
300+
},
301+
"loading": false,
302+
"networkStatus": 7
303+
}
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
{
2+
"type": "info",
3+
"now": "2025-09-29T17:59:34.422Z",
4+
"pr_number": 73752,
5+
"author": "sorskoot",
6+
"headCommitOid": "d95f839e8f8a345c37ebd7b242447c8fa4d1971b",
7+
"mergeBaseOid": "bc685e16eb9e0c33df331e571993dd814aea9e20",
8+
"lastPushDate": "2025-09-26T13:21:09.000Z",
9+
"lastActivityDate": "2025-09-26T13:21:45.000Z",
10+
"hasMergeConflict": false,
11+
"isFirstContribution": false,
12+
"tooManyFiles": false,
13+
"hugeChange": false,
14+
"popularityLevel": "Critical",
15+
"pkgInfo": [
16+
{
17+
"name": "webxr",
18+
"kind": "edit",
19+
"files": [
20+
{
21+
"path": "types/webxr/index.d.ts",
22+
"kind": "definition"
23+
},
24+
{
25+
"path": "types/webxr/webxr-tests.ts",
26+
"kind": "test"
27+
}
28+
],
29+
"owners": [
30+
"robrohan",
31+
"RaananW",
32+
"capnmidnight",
33+
"sorskoot"
34+
],
35+
"addedOwners": [],
36+
"deletedOwners": [],
37+
"popularityLevel": "Critical"
38+
}
39+
],
40+
"reviews": [],
41+
"mainBotCommentID": 3338712396,
42+
"ciResult": "pass"
43+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
[
2+
{
3+
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
4+
"variables": {
5+
"input": {
6+
"id": "IC_kwDOAFz6BM7HALVM",
7+
"body": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
8+
}
9+
}
10+
}
11+
]
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"projectColumn": "Needs Maintainer Review",
3+
"labels": [
4+
"Critical package",
5+
"Author is Owner"
6+
],
7+
"responseComments": [
8+
{
9+
"tag": "welcome",
10+
"status": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
11+
},
12+
{
13+
"tag": "pinging-reviewers",
14+
"status": "🔔 @robrohan @RaananW @capnmidnight — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/73752/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
15+
}
16+
],
17+
"shouldClose": false,
18+
"shouldMerge": false,
19+
"shouldUpdateLabels": true
20+
}

packages/mergebot/src/pr-info.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -600,6 +600,8 @@ function getReviews(prInfo: PR_repository_pullRequest) {
600600
if (reviewer === prInfo.author!.login) continue;
601601
// Only look at the most recent review per person (ignoring pending/commented)
602602
if (reviews.some((r) => sameUser(r.reviewer, reviewer))) continue;
603+
// Skip bot reviews
604+
if (!authorNotBot(r)) continue;
603605
// collect reviews by type
604606
if (r.commit.oid !== headCommitOid) {
605607
reviews.push({ type: "stale", reviewer, date, abbrOid: abbrOid(r.commit.oid) });

0 commit comments

Comments
 (0)