Raytracing tail call hello world #822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist4>::ptr_': cannot access protected member declared in class 'Microsoft::WRL::ComPtr<ID3D12GraphicsCommandList4>'
fix crash in the ray tracing miniengine example on a case where one has several gpus and the first one of them does not support dxr
intel recommend tail call optimization, which means roughly that TraceRay should be the last call in the ray gen. it saves context and calling back to the raygen shader.
|
@walbourn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel recommends to do tail call optimizations in raygen shaders, means TraceRay should be the last call
This saves the hardware time to recover after the call, fetch stuff and put it back
It is good this best practice to be right in the first example.