Add code review

Author: walbourn

CMakeLists.txt

@@ -92,10 +92,12 @@ install(FILES "${CMAKE_CURRENT_BINARY_DIR}/DirectXMath.pc"
 
 #--- Optional extension libraries
 if(BUILD_XDSP)
+  message(STATUS "Including XDSP Digital Signal Processing (DSP)")
   add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/XDSP)
 endif()
 
 if(BUILD_SHMATH)
+  message(STATUS "Including C++ Spherical Harmonics Math")
   add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/SHMath)
 endif()
 

SHMath/CMakeLists.txt

@@ -59,7 +59,7 @@ if(WIN32 AND BUILD_DX11)
   set(LIBRARY_SOURCES ${LIBRARY_SOURCES} DirectXSHD3D11.cpp)
 endif()
 
-if(BUILD_DX12)
+if(WIN32 AND BUILD_DX12)
   set(LIBRARY_SOURCES ${LIBRARY_SOURCES} DirectXSHD3D12.cpp)
 endif()
 
@@ -71,6 +71,20 @@ target_include_directories(${PROJECT_NAME} PUBLIC
 
 target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_11)
 
+if(MINGW)
+    find_package(directx-headers CONFIG REQUIRED)
+    target_link_libraries(${PROJECT_NAME} PUBLIC Microsoft::DirectX-Headers)
+    target_compile_definitions(${PROJECT_NAME} PUBLIC USING_DIRECTX_HEADERS)
+else()
+    find_package(directx-headers CONFIG QUIET)
+endif()
+
+if(directx-headers_FOUND)
+    message(STATUS "Using DirectX-Headers package")
+    target_link_libraries(${PROJECT_NAME} PRIVATE Microsoft::DirectX-Headers)
+    target_compile_definitions(${PROJECT_NAME} PRIVATE USING_DIRECTX_HEADERS)
+endif()
+
 #--- Package
 include(CMakePackageConfigHelpers)
 

SHMath/DirectXSHD3D12.cpp

@@ -16,7 +16,11 @@
 // C5039 pointer or reference to potentially throwing function passed to extern C function under - EHc
 #endif
 
+#ifdef USING_DIRECTX_HEADERS
+#include <directx/d3d12.h>
+#else
 #include <d3d12.h>
+#endif
 
 #include "DirectXSH.h"
 
@@ -224,7 +228,7 @@ HRESULT DirectX::SHProjectCubeMap(
 
     // index from [0,W-1], f(0) maps to -1 + 1/W, f(W-1) maps to 1 - 1/w
     // linear function x*S +B, 1st constraint means B is (-1+1/W), plug into
-    // second and solve for S: S = 2*(1-1/W)/(W-1). The old code that did 
+    // second and solve for S: S = 2*(1-1/W)/(W-1). The old code that did
     // this was incorrect - but only for computing the differential solid
     // angle, where the final value was 1.0 instead of 1-1/w...