Fixed -Wreserved-identifier warnings with clang v13

Author: walbourn

Inc/DirectXCollision.h

@@ -185,8 +185,8 @@ namespace DirectX
         BoundingOrientedBox(BoundingOrientedBox&&) = default;
         BoundingOrientedBox& operator=(BoundingOrientedBox&&) = default;
 
-        constexpr BoundingOrientedBox(_In_ const XMFLOAT3& _Center, _In_ const XMFLOAT3& _Extents, _In_ const XMFLOAT4& _Orientation) noexcept
-            : Center(_Center), Extents(_Extents), Orientation(_Orientation) {}
+        constexpr BoundingOrientedBox(_In_ const XMFLOAT3& center, _In_ const XMFLOAT3& extents, _In_ const XMFLOAT4& orientation) noexcept
+            : Center(center), Extents(extents), Orientation(orientation) {}
 
         // Methods
         void    XM_CALLCONV     Transform(_Out_ BoundingOrientedBox& Out, _In_ FXMMATRIX M) const noexcept;
@@ -254,12 +254,12 @@ namespace DirectX
         BoundingFrustum(BoundingFrustum&&) = default;
         BoundingFrustum& operator=(BoundingFrustum&&) = default;
 
-        constexpr BoundingFrustum(_In_ const XMFLOAT3& _Origin, _In_ const XMFLOAT4& _Orientation,
-            _In_ float _RightSlope, _In_ float _LeftSlope, _In_ float _TopSlope, _In_ float _BottomSlope,
-            _In_ float _Near, _In_ float _Far) noexcept
-            : Origin(_Origin), Orientation(_Orientation),
-            RightSlope(_RightSlope), LeftSlope(_LeftSlope), TopSlope(_TopSlope), BottomSlope(_BottomSlope),
-            Near(_Near), Far(_Far) {}
+        constexpr BoundingFrustum(_In_ const XMFLOAT3& origin, _In_ const XMFLOAT4& orientation,
+            _In_ float rightSlope, _In_ float leftSlope, _In_ float topSlope, _In_ float bottomSlope,
+            _In_ float nearPlane, _In_ float farPlane) noexcept
+            : Origin(origin), Orientation(orientation),
+            RightSlope(rightSlope), LeftSlope(leftSlope), TopSlope(topSlope), BottomSlope(bottomSlope),
+            Near(nearPlane), Far(farPlane) {}
         BoundingFrustum(_In_ CXMMATRIX Projection, bool rhcoords = false) noexcept;
 
         // Methods

SHMath/DirectXSHD3D11.cpp

@@ -98,7 +98,7 @@ namespace
 #pragma warning(disable : 6101)
 #endif
     _Success_(return)
-        bool _LoadScanline(
+        bool LoadScanline(
             _Out_writes_(count) DirectX::XMVECTOR* pDestination,
             size_t count,
             _In_reads_bytes_(size) LPCVOID pSource,
@@ -214,7 +214,7 @@ HRESULT DirectX::SHProjectCubeMap(
     case DXGI_FORMAT_R16G16_FLOAT:
     case DXGI_FORMAT_R32_FLOAT:
     case DXGI_FORMAT_R16_FLOAT:
-        // See _LoadScanline to support more pixel formats
+        // See LoadScanline to support more pixel formats
         break;
 
     default:
@@ -293,7 +293,7 @@ HRESULT DirectX::SHProjectCubeMap(
         for (UINT y = 0; y < desc.Height; ++y)
         {
             XMVECTOR* ptr = scanline.get();
-            if (!_LoadScanline(ptr, desc.Width, pSrc, mapped.RowPitch, desc.Format))
+            if (!LoadScanline(ptr, desc.Width, pSrc, mapped.RowPitch, desc.Format))
             {
                 context->Unmap(texture, dindex);
                 return E_FAIL;

SHMath/DirectXSHD3D12.cpp

@@ -93,7 +93,7 @@ namespace
 #pragma warning(disable : 6101)
 #endif
     _Success_(return)
-        bool _LoadScanline(
+        bool LoadScanline(
             _Out_writes_(count) DirectX::XMVECTOR* pDestination,
             size_t count,
             _In_reads_bytes_(size) LPCVOID pSource,
@@ -204,7 +204,7 @@ HRESULT DirectX::SHProjectCubeMap(
     case DXGI_FORMAT_R16G16_FLOAT:
     case DXGI_FORMAT_R32_FLOAT:
     case DXGI_FORMAT_R16_FLOAT:
-        // See _LoadScanline to support more pixel formats
+        // See LoadScanline to support more pixel formats
         break;
 
     default:
@@ -252,7 +252,7 @@ HRESULT DirectX::SHProjectCubeMap(
         for (UINT y = 0; y < desc.Height; ++y)
         {
             XMVECTOR* ptr = scanline.get();
-            if (!_LoadScanline(ptr, static_cast<size_t>(desc.Width), pSrc, static_cast<size_t>(cubeMap[face].RowPitch), desc.Format))
+            if (!LoadScanline(ptr, static_cast<size_t>(desc.Width), pSrc, static_cast<size_t>(cubeMap[face].RowPitch), desc.Format))
             {
                 return E_FAIL;
             }