Skip to content

Commit 8cf35a7

Browse files
authored
Code review feedback for DLL declimport/export (#214)
1 parent 5136747 commit 8cf35a7

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: approver_count
2+
description: Approver count policy for mscodehub/DirectXMesh/DirectXMesh repository
3+
resource: repository
4+
where:
5+
configuration:
6+
approverCountPolicySettings:
7+
isBlocking: true
8+
requireMinimumApproverCount: 1
9+
creatorVoteCounts: false
10+
allowDownvotes: false
11+
sourcePushOptions:
12+
resetOnSourcePush: false
13+
requireVoteOnLastIteration: true
14+
requireVoteOnEachIteration: false
15+
resetRejectionsOnSourcePush: false
16+
blockLastPusherVote: true
17+
branchNames:
18+
- refs/heads/release
19+
- refs/heads/main
20+
displayName: mscodehub/DirectXMesh/DirectXMesh Approver Count Policy

DirectXMesh/DirectXMesh.h

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,18 @@
4242

4343
#define DIRECTX_MESH_VERSION 168
4444

45-
#ifdef DIRECTX_MESH_EXPORT
45+
#if defined(_WIN32) && defined(DIRECTX_MESH_EXPORT)
46+
#ifdef __GNUC__
47+
#define DIRECTX_MESH_API __attribute__ ((dllexport))
48+
#else
4649
#define DIRECTX_MESH_API __declspec(dllexport)
47-
#elif defined(DIRECTX_MESH_IMPORT)
50+
#endif
51+
#elif defined(_WIN32) && defined(DIRECTX_MESH_IMPORT)
52+
#ifdef __GNUC__
53+
#define DIRECTX_MESH_API __attribute__ ((dllimport))
54+
#else
4855
#define DIRECTX_MESH_API __declspec(dllimport)
56+
#endif
4957
#else
5058
#define DIRECTX_MESH_API
5159
#endif

0 commit comments

Comments
 (0)