Skip to content

Commit e431247

Browse files
authored
CMake updates (#242)
1 parent d55336e commit e431247

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

CMakeLists.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,12 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
295295
endforeach()
296296
endif()
297297

298-
set(WarningsEXE "/wd4061" "/wd4365" "/wd4514" "/wd4571" "/wd4625" "/wd4626" "/wd4627" "/wd4668" "/wd4710" "/wd4711" "/wd4751" "/wd4774" "/wd4820" "/wd5026" "/wd5027" "/wd5039" "/wd5045" "/wd5219")
298+
set(WarningsEXE /wd4061 /wd4365 /wd4514 /wd4571 /wd4625 /wd4626 /wd4627 /wd4668 /wd4710 /wd4711 /wd4751 /wd4774 /wd4820 /wd5026 /wd5027 /wd5039 /wd5045 /wd5219)
299299
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.34)
300-
list(APPEND WarningsEXE "/wd5262" "/wd5264")
300+
list(APPEND WarningsEXE /wd5262 /wd5264)
301+
endif()
302+
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.50)
303+
list(APPEND WarningsEXE /wd4865)
301304
endif()
302305
foreach(t IN LISTS TOOL_EXES)
303306
target_compile_options(${t} PRIVATE ${WarningsEXE})

DirectXMesh/DirectXMeshP.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
#ifdef _MSC_VER
1515
// Off by default warnings
16-
#pragma warning(disable : 4619 4616 4061 4365 4514 4571 4623 4625 4626 4628 4668 4710 4711 4746 4774 4820 4987 5026 5027 5031 5032 5039 5045 5219 5246 5264 26812)
16+
#pragma warning(disable : 4619 4616 4061 4365 4514 4571 4623 4625 4626 4628 4668 4710 4711 4746 4774 4820 4865 4987 5026 5027 5031 5032 5039 5045 5219 5246 5264 26812)
1717
// C4619/4616 #pragma warning warnings
1818
// C4061 enumerator 'X' in switch of enum 'X' is not explicitly handled by a case label
1919
// C4365 signed/unsigned mismatch
@@ -29,6 +29,7 @@
2929
// C4746 volatile access of '<expression>' is subject to /volatile:<iso|ms> setting
3030
// C4774 format string expected in argument 3 is not a string literal
3131
// C4820 padding added after data member
32+
// C4865 the underlying type will change from 'int' to 'unsigned int' when '/Zc:enumTypes' is specified on the command line
3233
// C4987 nonstandard extension used
3334
// C5026 move constructor was implicitly defined as deleted
3435
// C5027 move assignment operator was implicitly defined as deleted

build/CompilerAndLinker.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
193193
endif()
194194

195195
if(WINDOWS_STORE AND (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.32))
196-
list(APPEND COMPILER_SWITCHES "/wd5246")
196+
list(APPEND COMPILER_SWITCHES /wd5246)
197197
endif()
198198

199199
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.35)

0 commit comments

Comments
 (0)