Skip to content

Commit 15fceac

Browse files
committed
address Damyan: specify constructors in interface, remove cleanup from interface
1 parent 0aa3c8d commit 15fceac

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

include/dxc/Support/dxcapi.extval.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class DxcDllExtValidationLoader : public DllLoader {
4242

4343
bool IsEnabled() const override { return DxCompilerSupport.IsEnabled(); }
4444

45-
void Cleanup() override {
45+
void Cleanup() {
4646
DxilExtValSupport.Cleanup();
4747
DxCompilerSupport.Cleanup();
4848
}

include/dxc/Support/dxcapi.use.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ extern const char *kDxilLib;
2323
class DllLoader {
2424
public:
2525
virtual HRESULT OverrideDll(LPCSTR dll, LPCSTR entryPoint) = 0;
26+
DllLoader() = default;
27+
DllLoader(const DllLoader &) = delete;
28+
DllLoader(DllLoader &&) = delete;
2629

2730
protected:
2831
virtual HRESULT CreateInstanceImpl(REFCLSID clsid, REFIID riid,
@@ -55,7 +58,6 @@ class DllLoader {
5558

5659
virtual bool IsEnabled() const = 0;
5760

58-
virtual void Cleanup() = 0;
5961
virtual HMODULE Detach() = 0;
6062
};
6163

@@ -177,7 +179,7 @@ class SpecificDllLoader : public DllLoader {
177179
return true;
178180
}
179181

180-
void Cleanup() override {
182+
void Cleanup() {
181183
if (m_dll != nullptr) {
182184
m_createFn = nullptr;
183185
m_createFn2 = nullptr;

0 commit comments

Comments
 (0)