Skip to content

Commit 4e0f536

Browse files
authored
[NFC] Clear some clang-tidy warnings, small cleaup hctdb.py (#7724)
The majority of this change is just deleting and unnesting `else` cases that follow `if () { return }` blocks There are a couple removals of `{}` around one-line branches, and then I updated `hctdb.py` to use the built in helper function for reserved ops that were manually being reserved.
1 parent 4e18ca3 commit 4e0f536

File tree

4 files changed

+207
-328
lines changed

4 files changed

+207
-328
lines changed

docs/DXIL.rst

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2340,18 +2340,18 @@ ID Name Description
23402340
223 TextureGatherRaw Gather raw elements from 4 texels with no type conversions (SRV type is constrained)
23412341
224 SampleCmpLevel samples a texture and compares a single component against the specified comparison value
23422342
225 TextureStoreSample stores texel data at specified sample index
2343-
226 Reserved0 Reserved
2344-
227 Reserved1 Reserved
2345-
228 Reserved2 Reserved
2346-
229 Reserved3 Reserved
2347-
230 Reserved4 Reserved
2348-
231 Reserved5 Reserved
2349-
232 Reserved6 Reserved
2350-
233 Reserved7 Reserved
2351-
234 Reserved8 Reserved
2352-
235 Reserved9 Reserved
2353-
236 Reserved10 Reserved
2354-
237 Reserved11 Reserved
2343+
226 Reserved0 reserved
2344+
227 Reserved1 reserved
2345+
228 Reserved2 reserved
2346+
229 Reserved3 reserved
2347+
230 Reserved4 reserved
2348+
231 Reserved5 reserved
2349+
232 Reserved6 reserved
2350+
233 Reserved7 reserved
2351+
234 Reserved8 reserved
2352+
235 Reserved9 reserved
2353+
236 Reserved10 reserved
2354+
237 Reserved11 reserved
23552355
238 AllocateNodeOutputRecords returns a handle for the output records
23562356
239 GetNodeRecordPtr retrieve node input/output record pointer in address space 6
23572357
240 IncrementOutputCount Select the next logical output count for an EmptyNodeOutput for the whole group or per thread.

include/dxc/DXIL/DxilConstants.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -496,18 +496,18 @@ inline bool IsFeedbackTexture(DXIL::ResourceKind ResourceKind) {
496496
// Enumeration for operations specified by DXIL
497497
enum class OpCode : unsigned {
498498
//
499-
Reserved0 = 226, // Reserved
500-
Reserved1 = 227, // Reserved
501-
Reserved10 = 236, // Reserved
502-
Reserved11 = 237, // Reserved
503-
Reserved2 = 228, // Reserved
504-
Reserved3 = 229, // Reserved
505-
Reserved4 = 230, // Reserved
506-
Reserved5 = 231, // Reserved
507-
Reserved6 = 232, // Reserved
508-
Reserved7 = 233, // Reserved
509-
Reserved8 = 234, // Reserved
510-
Reserved9 = 235, // Reserved
499+
Reserved0 = 226, // reserved
500+
Reserved1 = 227, // reserved
501+
Reserved10 = 236, // reserved
502+
Reserved11 = 237, // reserved
503+
Reserved2 = 228, // reserved
504+
Reserved3 = 229, // reserved
505+
Reserved4 = 230, // reserved
506+
Reserved5 = 231, // reserved
507+
Reserved6 = 232, // reserved
508+
Reserved7 = 233, // reserved
509+
Reserved8 = 234, // reserved
510+
Reserved9 = 235, // reserved
511511
ReservedA0 = 259, // reserved
512512
ReservedA1 = 260, // reserved
513513
ReservedA2 = 261, // reserved

0 commit comments

Comments
 (0)