Skip to content

Commit 68e3daa

Browse files
committed
remove unneeded functions, addressing Damyan
1 parent be99192 commit 68e3daa

File tree

2 files changed

+1
-21
lines changed

2 files changed

+1
-21
lines changed

include/dxc/Support/dxcapi.extval.h

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -26,26 +26,6 @@ class DxcDllExtValidationLoader : public DllLoader {
2626

2727
HRESULT Initialize() { return InitializeInternal("DxcCreateInstance"); }
2828

29-
/* Note, OverrideDll takes this dll argument and ignores it
30-
to satisfy the IDllLoader interface. The parameter is ignored
31-
because the relevant dlls are specific and known: dxcompiler.dll
32-
and dxil.dll. This class is not designed to handle any other dlls */
33-
HRESULT OverrideDll(LPCSTR dll, LPCSTR entryPoint) {
34-
return InitializeInternal(entryPoint);
35-
}
36-
37-
bool HasCreateWithMalloc() const {
38-
assert(DxCompilerSupport.HasCreateWithMalloc() &&
39-
DxilExtValSupport.HasCreateWithMalloc());
40-
return true;
41-
}
42-
4329
bool IsEnabled() const override { return DxCompilerSupport.IsEnabled(); }
44-
45-
HMODULE Detach() {
46-
// Can't Detach and return a handle for DxilSupport. Cleanup() instead.
47-
DxilExtValSupport.Cleanup();
48-
return DxCompilerSupport.Detach();
49-
}
5030
};
5131
} // namespace dxc

0 commit comments

Comments
 (0)