Skip to content

Commit c8d867e

Browse files
committed
add more overrides
1 parent daf6f0a commit c8d867e

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

include/dxc/Support/dxcapi.extval.h

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,35 @@ class DxcDllExtValidationLoader : public DllLoader {
1919
return !DxilDllPath.empty() && !DxilExtValSupport.IsEnabled();
2020
}
2121

22-
HRESULT CreateInstanceImpl(REFCLSID clsid, REFIID riid, IUnknown **pResult);
22+
HRESULT CreateInstanceImpl(REFCLSID clsid, REFIID riid,
23+
IUnknown **pResult) override;
2324
HRESULT CreateInstance2Impl(IMalloc *pMalloc, REFCLSID clsid, REFIID riid,
24-
IUnknown **pResult);
25+
IUnknown **pResult) override;
2526

2627
HRESULT Initialize() { return InitializeInternal("DxcCreateInstance"); }
2728

2829
/* Note, OverrideDll takes this dll argument and ignores it
2930
to satisfy the IDllLoader interface. The parameter is ignored
3031
because the relevant dlls are specific and known: dxcompiler.dll
3132
and dxil.dll. This class is not designed to handle any other dlls */
32-
HRESULT OverrideDll(LPCSTR dll, LPCSTR entryPoint) {
33+
HRESULT OverrideDll(LPCSTR dll, LPCSTR entryPoint) override {
3334
return InitializeInternal(entryPoint);
3435
}
3536

36-
bool HasCreateWithMalloc() const {
37+
bool HasCreateWithMalloc() const override {
3738
assert(DxCompilerSupport.HasCreateWithMalloc() &&
3839
DxilExtValSupport.HasCreateWithMalloc());
3940
return true;
4041
}
4142

42-
bool IsEnabled() const { return DxCompilerSupport.IsEnabled(); }
43+
bool IsEnabled() const override { return DxCompilerSupport.IsEnabled(); }
4344

4445
void Cleanup() override {
4546
DxilExtValSupport.Cleanup();
4647
DxCompilerSupport.Cleanup();
4748
}
4849

49-
HMODULE Detach() {
50+
HMODULE Detach() override {
5051
// Can't Detach and return a handle for DxilSupport. Cleanup() instead.
5152
DxilExtValSupport.Cleanup();
5253
return DxCompilerSupport.Detach();

0 commit comments

Comments
 (0)