Skip to content

NFC: Report error on dxc --version instead of error on None group #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NFC: Report error on dxc --version instead of error on None group #7505

wants to merge 1 commit into from
+4 −0

Conversation

tex3d
Copy link
Contributor

@tex3d tex3d commented Jun 3, 2025

This adds better error handling for dxc --version used to get the dxil version in tools/clang/test/lit.cfg in case the dxc call fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tex3d @llvm-beanz