Fix SV_PrimitiveID in GSVIn #7624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiles now also allow fvk-invert-y.
…t; avoids pixel shader from inverting SV_POSITION.y in a lib file
…nly supported on GS/VS/DS/MS already. Added test case for fvk-invert-y for lib files
…owed to be flipped
…PrimitiveID from Vertex->Geometry shaders (GSVIn) even though according to the spec it should be allowed. This breaks existing shaders but only if they're compiled as lib file (compiling it with gs_ is fine). This is because the value in this table is NA, which results in the semantic becoming invalid and down the road that results in this error: "Semantic 'SV_PrimitiveID' is invalid as gs Input."
…iler into fix_sv_primitive_id_in_gsvin
|
Fixes #7625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSVIn doesn't permit usage of SV_PrimitiveID, even though according to the spec this is allowed.
This happens if you try to compile GS with SV_PrimitiveID with lib_ target rather than gs_.
This can break some shaders that can use IDxcLinker together with lib_.