Fix typo of register -> registers crashes DXC with segfault #7729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t segfault the compiler anymore. Instead, it assumes that when you write : MYTEST() that you're intending to make it into a register, will parse the register the normal way to skip invalid syntax and will show an error that you shouldn't do that.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6599
The issue is that it tries to parse a register definition as a semantic and the remainder
(space1)will be unrecognized and completely mess everything up.Instead, I still try to parse it as a register and give the errors you'd get if it was a real register. Of course it isn't a register, so the register assignment will get dropped and an error gets given instead:
Syntax similar to : register() was used but unexpected keyword 'registers' was used instead.