Update Cooperative Vector Operations to require 6.10 as the minimum target shader model #7815
+95
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenatali
approved these changes
Oct 10, 2025
damyanp
requested changes
Oct 11, 2025
You can test this locally with the following command:darker --check --diff -r 0bf8434bc3b57a0b99477162dfe54673d9b5153b..fb4951ba0835f19242651fc88ed1d47e4ce12f5c utils/hct/hctdb.pyView the diff from darker here.--- hctdb.py 2025-10-13 21:11:40.000000 +0000
+++ hctdb.py 2025-10-13 21:12:42.250574 +0000
@@ -6378,12 +6378,12 @@
next_op_idx += 1
# End of DXIL 1.9 opcodes.
self.set_op_count_for_version(1, 9, next_op_idx)
assert next_op_idx == 312, (
- "312 is expected next operation index but encountered %d and thus opcodes are broken"
- % next_op_idx
+ "312 is expected next operation index but encountered %d and thus opcodes are broken"
+ % next_op_idx
)
# Set interesting properties.
self.build_indices()
for (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies all cooperative vector operations to require a minimum target shader model of 6.10. It updates the associated tests to also target 6.10.
Fixes #7771