Ensure -Wmicrosoft-cast is ignored

walbourn · walbourn · commit bb3ff0f78ead · 2025-10-30T11:40:17.000-07:00
diff --git a/Src/GamePad.cpp b/Src/GamePad.cpp
@@ -98,6 +98,10 @@ using namespace GameInput::v3;
 
 using GameInputCreateFn = HRESULT(*)(IGameInput**);
 
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wmicrosoft-cast"
+#endif
+
 class GamePad::Impl
 {
 public:
@@ -122,7 +126,7 @@ class GamePad::Impl
             s_gameInputModule = LoadLibraryExW(L"GameInput.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
             if (s_gameInputModule)
             {
-                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(static_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
+                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(reinterpret_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
             }
 
             if (!s_gameInputCreate)
diff --git a/Src/Keyboard.cpp b/Src/Keyboard.cpp
@@ -65,6 +65,10 @@ using namespace GameInput::v3;
 
 using GameInputCreateFn = HRESULT(*)(IGameInput**);
 
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wmicrosoft-cast"
+#endif
+
 class Keyboard::Impl
 {
 public:
@@ -89,7 +93,7 @@ class Keyboard::Impl
             s_gameInputModule = LoadLibraryExW(L"GameInput.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
             if (s_gameInputModule)
             {
-                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(static_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
+                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(reinterpret_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
             }
 
             if (!s_gameInputCreate)
diff --git a/Src/Mouse.cpp b/Src/Mouse.cpp
@@ -33,6 +33,10 @@ using namespace GameInput::v3;
 
 using GameInputCreateFn = HRESULT(*)(IGameInput**);
 
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wmicrosoft-cast"
+#endif
+
 //
 // Call this static function from your Window Message Procedure
 //
@@ -93,7 +97,7 @@ class Mouse::Impl
             s_gameInputModule = LoadLibraryExW(L"GameInput.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
             if (s_gameInputModule)
             {
-                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(static_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
+                s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(reinterpret_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));
             }
 
             if (!s_gameInputCreate)

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,10 @@ using namespace GameInput::v3;`
`98`	`98`
`99`	`99`	`using GameInputCreateFn = HRESULT()(IGameInput*);`
`100`	`100`
	`101`	`+#ifdef __clang__`
	`102`	`+#pragma clang diagnostic ignored "-Wmicrosoft-cast"`
	`103`	`+#endif`
	`104`	`+`
`101`	`105`	`class GamePad::Impl`
`102`	`106`	`{`
`103`	`107`	`public:`
`@@ -122,7 +126,7 @@ class GamePad::Impl`
`122`	`126`	`s_gameInputModule = LoadLibraryExW(L"GameInput.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);`
`123`	`127`	`if (s_gameInputModule)`
`124`	`128`	`{`
`125`		`- s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(static_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));`
	`129`	`+ s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(reinterpret_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));`
`126`	`130`	`}`
`127`	`131`
`128`	`132`	`if (!s_gameInputCreate)`
Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,10 @@ using namespace GameInput::v3;`
`65`	`65`
`66`	`66`	`using GameInputCreateFn = HRESULT()(IGameInput*);`
`67`	`67`
	`68`	`+#ifdef __clang__`
	`69`	`+#pragma clang diagnostic ignored "-Wmicrosoft-cast"`
	`70`	`+#endif`
	`71`	`+`
`68`	`72`	`class Keyboard::Impl`
`69`	`73`	`{`
`70`	`74`	`public:`
`@@ -89,7 +93,7 @@ class Keyboard::Impl`
`89`	`93`	`s_gameInputModule = LoadLibraryExW(L"GameInput.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);`
`90`	`94`	`if (s_gameInputModule)`
`91`	`95`	`{`
`92`		`- s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(static_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));`
	`96`	`+ s_gameInputCreate = reinterpret_cast<GameInputCreateFn>(reinterpret_cast<void*>(GetProcAddress(s_gameInputModule, "GameInputCreate")));`
`93`	`97`	`}`
`94`	`98`
`95`	`99`	`if (!s_gameInputCreate)`