Code review for ModelMeshPart collection (#532)

Author: walbourn

Src/ModelLoadCMO.cpp

@@ -767,7 +767,7 @@ std::unique_ptr<Model> DirectX::Model::CreateFromCMO(
 
             auto& mat = materials[sm.MaterialIndex];
 
-            auto part = new ModelMeshPart();
+            auto part = std::make_unique<ModelMeshPart>();
 
             if (mat.pMaterial->Diffuse.w < 1)
                 part->isAlpha = true;
@@ -781,7 +781,7 @@ std::unique_ptr<Model> DirectX::Model::CreateFromCMO(
             part->effect = mat.effect;
             part->vbDecl = enableSkinning ? g_vbdeclSkinning : g_vbdecl;
 
-            mesh->meshParts.emplace_back(part);
+            mesh->meshParts.emplace_back(std::move(part));
         }
 
         model->meshes.emplace_back(mesh);

Src/ModelLoadSDKMESH.cpp

@@ -704,7 +704,7 @@ std::unique_ptr<Model> DirectX::Model::CreateFromSDKMESH(
 
             SetDebugObjectName(il.Get(), "ModelSDKMESH");
 
-            auto part = new ModelMeshPart();
+            auto part = std::make_unique<ModelMeshPart>();
             part->isAlpha = mat.alpha;
 
             part->indexCount = static_cast<uint32_t>(subset.IndexCount);
@@ -719,7 +719,7 @@ std::unique_ptr<Model> DirectX::Model::CreateFromSDKMESH(
             part->effect = mat.effect;
             part->vbDecl = vbDecls[mh.VertexBuffers[0]];
 
-            mesh->meshParts.emplace_back(part);
+            mesh->meshParts.emplace_back(std::move(part));
         }
 
         model->meshes.emplace_back(mesh);

Src/ModelLoadVBO.cpp

@@ -152,7 +152,7 @@ std::unique_ptr<Model> DirectX::Model::CreateFromVBO(
 
     SetDebugObjectName(il.Get(), "ModelVBO");
 
-    auto part = new ModelMeshPart();
+    auto part = std::make_unique<ModelMeshPart>();
     part->indexCount = header->numIndices;
     part->startIndex = 0;
     part->vertexStride = static_cast<UINT>(sizeof(VertexPositionNormalTexture));
@@ -167,9 +167,11 @@ std::unique_ptr<Model> DirectX::Model::CreateFromVBO(
     mesh->pmalpha = (flags & ModelLoader_PremultipledAlpha) != 0;
     BoundingSphere::CreateFromPoints(mesh->boundingSphere, header->numVertices, &verts->position, sizeof(VertexPositionNormalTexture));
     BoundingBox::CreateFromPoints(mesh->boundingBox, header->numVertices, &verts->position, sizeof(VertexPositionNormalTexture));
-    mesh->meshParts.emplace_back(part);
+    mesh->meshParts.reserve(1);
+    mesh->meshParts.emplace_back(std::move(part));
 
     auto model = std::make_unique<Model>();
+    model->meshes.reserve(1);
     model->meshes.emplace_back(mesh);
 
     return model;