Gangams/fix pod ready for completed jobs (#933)

* fix issue pod ready condition for job ready pods

* fix issue pod ready condition for job ready pods

* fix issue pod ready condition for job ready pods

* fix issue pod ready condition for job ready pods

* fix pr feedback

Author: ganga1980

source/plugins/ruby/KubernetesApiClient.rb

@@ -1382,13 +1382,13 @@ def getHpaOptimizedItem(resourceItem)
       return item
     end
 
-    def getPodReadyCondition(podStatusConditions)
+    def getPodReadyCondition(podStatusConditions, controllerKind, podStatus)
       podReadyCondition = false
       begin
         if !podStatusConditions.nil? && !podStatusConditions.empty?
           podStatusConditions.each do |condition|
             if condition["type"] == "Ready"
-              if condition["status"].downcase == "true"
+              if condition["status"].downcase == "true" || isCompletedJobPod(controllerKind, podStatus)
                 podReadyCondition = true
               end
               break #Exit the for loop since we found the ready condition
@@ -1401,6 +1401,20 @@ def getPodReadyCondition(podStatusConditions)
       return podReadyCondition
     end
 
+    def isCompletedJobPod(controllerKind, podStatus)
+      isCompletedPod = false
+      begin
+        if !controllerKind.nil? & !controllerKind.empty? &&
+           !podStatus.nil? && !podStatus.empty? &&
+           controllerKind.downcase == Constants::CONTROLLER_KIND_JOB && podStatus == "Succeeded"
+          isCompletedPod = true
+        end
+      rescue => error
+        @Log.warn "in_kube_podinventory::isCompletedJobPod failed with an error: #{err}"
+      end
+      return isCompletedPod
+    end
+
     def isEmitCacheTelemetry
       isEmitCacheTelemtryEnabled = false
       if !ENV["EMIT_CACHE_TELEMETRY"].nil? && !ENV["EMIT_CACHE_TELEMETRY"].empty? && ENV["EMIT_CACHE_TELEMETRY"].downcase == "true"

source/plugins/ruby/in_kube_podinventory.rb

@@ -563,8 +563,8 @@ def getPodInventoryRecords(item, serviceRecords, batchTime = Time.utc.iso8601)
         mdmPodRecord["ControllerName"] = record["ControllerName"]
         mdmPodRecord["Namespace"] = record["Namespace"]
         mdmPodRecord["PodStatus"] = record["PodStatus"]
-        mdmPodRecord["PodReadyCondition"] = KubernetesApiClient.getPodReadyCondition(item["status"]["conditions"])
         mdmPodRecord["ControllerKind"] = record["ControllerKind"]
+        mdmPodRecord["PodReadyCondition"] = KubernetesApiClient.getPodReadyCondition(item["status"]["conditions"], record["ControllerKind"], record["PodStatus"])
         mdmPodRecord["containerRecords"] = []
 
         podContainers = []