Skip to content

Commit 662bef0

Browse files
authored
Updated readme for conformance image (#1381)
1 parent 8867998 commit 662bef0

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,14 +390,19 @@ For our single branch ci_prod, automatically deployed latest yaml with latest ag
390390
## For adding new tests
391391

392392
1. Add the test python file with your test code under `tests` directory
393-
2. Build the docker image, recommended to use ACR & MCR
393+
2. Make sure all the files has Unix-style line ending (LF) instead of Windows-style (CRLF). Run below command to convert all files in a directoty from CRLF to LF:
394+
```
395+
cd ~/Docker-Provider/test # based on your repo path
396+
find ./e2e -type f -exec sed -i 's/\r$//' {} +
397+
```
398+
3. Build the docker image, recommended to use ACR & MCR
394399
```
395400
cd ~/Docker-Provider/test/e2e/src # based on your repo path
396401
docker login <acr> -u <user> -p <pwd> # login to acr
397402
docker build -f ./core/Dockerfile -t <repo>/<imagename>:<imagetag> --build-arg PYTHON_BASE_IMAGE=<referInternalWikiForPythonBaseImage> .
398403
docker push <repo>/<imagename>:<imagetag>
399404
```
400-
3. update existing agentest image tag in e2e-tests.yaml & conformance.yaml with newly built image tag with MCR repo
405+
4. update existing agentest image tag in e2e-tests.yaml & conformance.yaml with newly built image tag with MCR repo
401406

402407
# Scenario Tests
403408
Clusters are used in release pipeline already has the yamls under test\scenario deployed. Make sure to validate these scenarios.

0 commit comments

Comments
 (0)