Merge pull request #195 from microsoft/psl-dev-US-13877

refactor: validated the isnull or empty variable

Author: Roopan-Microsoft

Deployment/resourcedeployment.ps1

@@ -176,15 +176,18 @@ function DeployAzureResources([string]$location, [string]$modelLocation) {
         if ($LASTEXITCODE -ne 0) {
             Write-Host "There might be something wrong with your deployment." -ForegroundColor Red
             Write-Host $whatIfResult -ForegroundColor Red
+            failureBanner
             exit 1            
         }
         # Proceed with the actual deployment
         Write-Host "Proceeding with Deployment..." -ForegroundColor Yellow
         $deploymentResult = az deployment sub create --template-file .\main.bicep --location $location --name $deploymentName --parameters modeldatacenter=$modelLocation
-
+        # Check if deploymentResult is valid        
+        ValidateVariableIsNullOrEmpty -variableValue $deploymentResult -variableName "Deployment Result"  
         if ($LASTEXITCODE -ne 0) {
             Write-Host "Deployment failed. Stopping execution." -ForegroundColor Red
             Write-Host $deploymentResult -ForegroundColor Red
+            failureBanner
             exit 1
         }
 
@@ -197,6 +200,7 @@ function DeployAzureResources([string]$location, [string]$modelLocation) {
         Write-Host $_.Exception.Message -ForegroundColor Red
         Write-Host $_.InvocationInfo.PositionMessage -ForegroundColor Red
         Write-Host $_.ScriptStackTrace -ForegroundColor Red
+        failureBanner
         exit 1
     }
 }
@@ -410,6 +414,7 @@ function Check-Docker {
 # Check if Docker is running before proceeding
 if (-not (Check-Docker)) {
     Write-Host "Docker is not running. Please start Docker and try again." -ForegroundColor Red
+    failureBanner
     exit 1
 }
 
@@ -439,6 +444,9 @@ try {
     # Step 2 : Get Secrets from Azure resources
     Show-Banner -Title "Step 2 : Get Secrets from Azure resources"
     ###############################################################
+    # Validate if the Storage Account Name is empty or null    
+    ValidateVariableIsNullOrEmpty -variableValue $deploymentResult.StorageAccountName -variableName "Storage Account Name"
+
     # Get the storage account key
     $storageAccountKey = az storage account keys list --account-name $deploymentResult.StorageAccountName --resource-group $deploymentResult.ResourceGroupName --query "[0].value" -o tsv
 
@@ -596,6 +604,7 @@ try {
 
     if ($retryCount -eq $maxRetries) {
         Write-Host "Max retries reached. Failed to update the AKS cluster." -ForegroundColor Red
+        failureBanner
         exit 1
     }
 
@@ -615,6 +624,7 @@ try {
         Write-Host "Error details:" -ForegroundColor Red
         Write-Host $_.Exception.Message -ForegroundColor Red
         Write-Host $_.Exception.StackTrace -ForegroundColor Red
+        failureBanner
         exit 1
     }
 
@@ -630,6 +640,7 @@ try {
         Write-Host "Error details:" -ForegroundColor Red
         Write-Host $_.Exception.Message -ForegroundColor Red
         Write-Host $_.Exception.StackTrace -ForegroundColor Red
+        failureBanner
         exit 1
     }
 
@@ -650,6 +661,7 @@ try {
         Write-Host "Error details:" -ForegroundColor Red
         Write-Host $_.Exception.Message -ForegroundColor Red
         Write-Host $_.Exception.StackTrace -ForegroundColor Red
+        failureBanner
         exit 1
     }
 
@@ -716,6 +728,9 @@ try {
     # Validate if System Assigned Identity is null or empty
     ValidateVariableIsNullOrEmpty -variableValue $systemAssignedIdentity -variableName "System-assigned managed identity"    
 
+     # Validate if ResourceGroupId is null or empty
+    ValidateVariableIsNullOrEmpty -variableValue $deploymentResult.ResourceGroupId -variableName "ResourceGroupId"    
+ 
     # Assign the role for aks system assigned managed identity to App Configuration Data Reader role with the scope of Resourcegroup
     az role assignment create --assignee $systemAssignedIdentity --role "App Configuration Data Reader" --scope $deploymentResult.ResourceGroupId
 
@@ -743,6 +758,7 @@ try {
         Write-Host "Error details:" -ForegroundColor Red
         Write-Host $_.Exception.Message -ForegroundColor Red
         Write-Host $_.Exception.StackTrace -ForegroundColor Red
+        failureBanner
         exit 1
     }
 
@@ -772,12 +788,21 @@ try {
 
 
     # 5.3 Update deploy.deployment.yaml.template file and save as deploy.deployment.yaml
+    # Validate AzContainerRegistryName IsNull Or Empty.
+    ValidateVariableIsNullOrEmpty -variableValue $deploymentResult.AzContainerRegistryName -variableName "Azure Container Registry Name"
+
     ## Define Image Tags
     $acrNamespace = "kmgs"
     $acrAIServiceTag = "$($deploymentResult.AzContainerRegistryName).azurecr.io/$acrNamespace/aiservice"
     $acrKernelMemoryTag = "$($deploymentResult.AzContainerRegistryName).azurecr.io/$acrNamespace/kernelmemory"
     $acrFrontAppTag = "$($deploymentResult.AzContainerRegistryName).azurecr.io/$acrNamespace/frontapp"
-
+    
+    # Validate AI Service Tag IsNull Or Empty.    
+    ValidateVariableIsNullOrEmpty -variableValue $acrAIServiceTag -variableName "AI Service Tag"
+    # Validate Kernel Memory Tag IsNull Or Empty.   
+    ValidateVariableIsNullOrEmpty -variableValue $acrKernelMemoryTag -variableName "Kernel Memory Tag"
+    # Validate Front App Tag IsNull Or Empty.   
+    ValidateVariableIsNullOrEmpty -variableValue $acrFrontAppTag -variableName "Front App Tag"
 
     $deploymentTemplatePlaceholders = @{
         '{{ aiservice-imagepath }}' = $acrAIServiceTag
@@ -821,8 +846,9 @@ try {
 
 
 #======================================================================================================================================================================
+    # Validate AzAppConfigEndpoint IsNull Or Empty.
+    ValidateVariableIsNullOrEmpty -variableValue $deploymentResult.AzAppConfigEndpoint -variableName "Azure App Configuration Endpoint"
     # App Deployment after finishing the AKS infrastructure setup
-    
     $appConfigServicePlaceholders = @{
         '{{ appconfig-url }}' = $deploymentResult.AzAppConfigEndpoint
     }