POS is getting crashed when appbar comand extension point is used for InventoryAdjustmentDocumentWorkingView

[alexanderkurilenko]

Noticed that when appbar extension (if registered) crashes the POS;

Steps to reproduce:

1) Create empty appbar command for InventoryAdjustmentDocumentWorkingView
Example :

import { IExtensionCommandContext } from "PosApi/Extend/Views/AppBarCommands";
import * as InventoryAdjustmentDocumentWorkingView from "PosApi/Extend/Views/InventoryAdjustmentDocumentWorkingView";

export default class InventoryDocumentWorkingViewCommand extends InventoryAdjustmentDocumentWorkingView.InventoryAdjustmentDocumentWorkingExtensionCommandBase {
constructor(context: IExtensionCommandContext<InventoryAdjustmentDocumentWorkingView.IInventoryAdjustmentDocumentWorkingToExtensionCommandMessageTypeMap>) {
super(context);

    this.id = "inventoryDocumentWorkingViewCommand";
    this.label = "CustomButton"
    this.extraClass = "iconAdd";


    this.documentLinesSelectedHandler = (data: InventoryAdjustmentDocumentWorkingView.InventoryAdjustmentDocumentWorkingLinesSelectedData): void => {
    };

    this.documentLinesLoadedHandler = (data): void => {
    };

    this.documentLinesSelectionClearedHandler = (): void => { };
    this.documentLineUpdatedHandler = (data) => {
    };
    this.documentUpdatedHandler = (data) => {
    };
    this.receiptsSelectedHandler = (data) => {
    };
    this.receiptsSelectionClearedHandler = () => {
    };

}

protected init(state: InventoryAdjustmentDocumentWorkingView.IInventoryAdjustmentDocumentWorkingExtensionCommandState): void {
    this.isVisible = true;

    this.canExecute = true;
}

protected execute(): void {
}

}_

2) Register this extension point in manifest
e.g
"InventoryAdjustmentDocumentWorkingView": {
 
  "appBarCommands": [
      { "modulePath": "ViewExtensions/InventoryAdjustmentDocumentWorking/InventoryDocumentWorkingViewCommand" }
  ]
}

3) After this cusomization is deployed, open InventoryDocumentWorkingViewCommand , button is added
4) Continue working with POS or wait couple of minutes, After several minutes from step 3, POS starting to crash during Dispose most likely

Errors from browser console:

_Diagnostics.TypeScriptCore.js:604
Unhandled App error: Cannot read properties of undefined (reading 'disableHeader');
StackTrace: TypeError: Cannot read properties of undefined (reading 'disableHeader')
at class_2.ComposableViewControllerAdapter [as constructor] (https://kap-dev18-1:446/POS/Pos.Views.js:8497:55)
at new class_2 (https://kap-dev18-1:446/POS/Pos.js:1504:39)
at PageControl_ctor.init (https://kap-dev18-1:446/POS/Pos.js:352:55)
at Pages_init (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26487:46)
at _Base.Class.derive._creator.CompletePromise_then [as then] (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:2510:49)
at new PageControl_ctor (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26484:45)
at Object.render (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26726:23)
at ViewNavigator.navigate (https://kap-dev18-1:446/POS/Pos.js:6591:32)
at ViewModelAdapterImpl.navigate (https://kap-dev18-1:446/POS/Pos.js:127:32)
at Object.navigate (https://kap-dev18-1:446/POS/Pos.js:1440:47); ErrorUrl: ''; ErrorObject: '{ baseError: '{"stack":"TypeError: Cannot read properties of undefined (reading 'disableHeader')\n at class_2.ComposableViewControllerAdapter [as constructor] (https://kap-dev18-1:446/POS/Pos.Views.js:8497:55)\n at new class_2 (https://kap-dev18-1:446/POS/Pos.js:1504:39)\n at PageControl_ctor.init (https://kap-dev18-1:446/POS/Pos.js:352:55)\n at Pages_init (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26487:46)\n at _Base.Class.derive._creator.CompletePromise_then [as then] (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:2510:49)\n at new PageControl_ctor (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26484:45)\n at Object.render (https://kap-dev18-1:446/POS/Libraries/winjs/js/base.js:26726:23)\n at ViewNavigator.navigate (https://kap-dev18-1:446/POS/Pos.js:6591:32)\n at ViewModelAdapterImpl.navigate (https://kap-dev18-1:446/POS/Pos.js:127:32)\n at Object.navigate (https://kap-dev18-1:446/POS/Pos.js:1440:47)","message":"Cannot read properties of undefined (reading 'disableHeader')","name":"TypeError","proto":{}}', mainError: '{"type":"error","detail":{"exception":null,"error":{},"promise":{"_isException":false,"_errorId":3},"id":3},"stoppedImmediatePropagation":false}' }'; View Name: 'InventoryAdjustmentDocumentListView'

Diagnostics.TypeScriptCore.js:604
Unhandled App error: Cannot read properties of undefined (reading 'sendMessage');
StackTrace: TypeError: Cannot read properties of undefined (reading 'sendMessage')
at CommandProxy.sendMessage (https://kap-dev18-1:446/POS/Pos.Framework.UI.Contracts.js:201:38)
at https://kap-dev18-1:446/POS/Pos.Framework.UI.js:1157:23
at Array.map ()
at ComposableCommandBar.dispose (https://kap-dev18-1:446/POS/Pos.Framework.UI.js:1156:38)
at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34)
at ObjectExtensions.disposeAllProperties (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:100:46)
at ComposableViewControllerBase.dispose (https://kap-dev18-1:446/POS/Pos.Framework.UI.js:994:43)
at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34)
at ComposableViewControllerAdapter.dispose (https://kap-dev18-1:446/POS/Pos.Views.js:8529:43)
at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34); ErrorUrl: 'https://kap-dev18-1:446/POS/Pos.Framework.UI.Contracts.js'; ErrorObject: '{ baseError: '{"stack":"TypeError: Cannot read properties of undefined (reading 'sendMessage')\n at CommandProxy.sendMessage (https://kap-dev18-1:446/POS/Pos.Framework.UI.Contracts.js:201:38)\n at https://kap-dev18-1:446/POS/Pos.Framework.UI.js:1157:23\n at Array.map ()\n at ComposableCommandBar.dispose (https://kap-dev18-1:446/POS/Pos.Framework.UI.js:1156:38)\n at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34)\n at ObjectExtensions.disposeAllProperties (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:100:46)\n at ComposableViewControllerBase.dispose (https://kap-dev18-1:446/POS/Pos.Framework.UI.js:994:43)\n at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34)\n at ComposableViewControllerAdapter.dispose (https://kap-dev18-1:446/POS/Pos.Views.js:8529:43)\n at ObjectExtensions.tryDispose (https://kap-dev18-1:446/POS/Commerce.TypeExtensions.Public.js:79:34)","message":"Cannot read properties of undefined (reading 'sendMessage')","name":"TypeError","proto":{}}', mainError: '{"type":"error","detail":{"error":{"isTrusted":true,"message":"Uncaught TypeError: Cannot read properties of undefined (reading 'sendMessage')","filename":"https://kap-dev18-1:446/POS/Pos.Framework.UI.Contracts.js","lineno":201,"colno":38,"error":{},"type":"error","target":{"0":{"document":{"location":{"ancestorOrigins":{"0":"https://kap-dev18-1:446"},"href":"about:blank","origin":"null","protocol":"about:","host":"","hostname":"","port":"","pathname":"blank","search":"","hash":""}},"name":"","customElements":{},"history":{},"navigation":{},"locationbar":{},"menubar":{},"personalbar":{},"scrollbars":{},"statusbar":{},"toolbar":{},"status":"","closed":false,"length":0,"opener":null,"frameElement":{"winControl":{"_disposed":false,"_elementLoaded":true,"_running":true,"_elementLoadPromise":{"_oncancel":null,"_nextState":null,"_state":{"name":"success","done":null,"then":null},"_listeners":null},"_listeners":{"resize":[{"useCapture":false}]},"_pendingResizeAnimationFrameId":18}},"navigator":{},"origin":"https://kap-dev18-1:446","external":{},"screen":{},"innerWidth":1396,"innerHeight":752,"scrollX":0,"pageXOffset":0,"scrollY":0,"pageYOffset":0,"visualViewport":{},"screenX":0,"screenY":0,"outerWidth":1920,"outerHeight":960,"devicePixelRatio":0.800000011920929,"screenLeft":0,"screenTop":0,"styleMedia":{},"onsearch":null,"isSecureContext":true,"trustedTypes":{},"performance":{"timeOrigin":1728563654465.2,"timing":{"connectStart":0,"secureConnectionStart":0,"unloadEventEnd":0,"domainLookupStart":0,"domainLookupEnd":0,"responseStart":0,"connectEnd":0,"responseEnd":1728563654468,"requestStart":0,"domLoading":1728563654466,"redirectStart":0,"loadEventEnd":1728563654468,"domComplete":1728563654468,"navigationStart":1728563654466,"loadEventStart":1728563654468,"domContentLoadedEventEnd":1728563654468,"unloadEventStart":0,"redirectEnd":0,"domInteractive":1728563654468,"fetchStart":0,"domContentLoadedEventStart":1728563654468},"navigation":{"type":0,"redirectCount":0}},"onappinstalled":null,"onbeforeinstallprompt":null,"crypto":{},"indexedDB":{},"sessionStorage":{"AITR_StringValueTooLong":"1","AI_buffer":"[]","AI_sentBuffer":"[]","AITR_OnError":"1"},"localStorage":{"INITIAL_SYNC_COMPLETED_KEY":"true","CONNECTION_STATUS":"0","DEVICE_TOKEN_KEY":"Support-HK:mqTfeQ2MrjFrlubzsS2dO2s7hND3+Tjz9D0XnobHrlJe2c2VJusOcfO2V9Kwz1N6hYnjy4bQSzRPDX51TkWCug==:5637144665:5637147579","HARDWARE_PROFILE_KEY":"{\"RecordId\":5637145328,\"LineDisplayDelayForLinkedItems\":0,\"LineDisplayBalanceText\":\"\",\"LineDisplayBinaryConversion\":fa

[madyke]

Hello @alexanderkurilenko - unfortunately, this is a known issue with the extension. We have filed an internal bug and hope to have a fix soon. You can follow this LCS Known Issue for updates on the fix:
InventoryAdjustmentDocumentWorkingExtensionCommandBase extension issue - Cannot read properties of undefined (reading 'disableHeader');