Skip to content

Commit 8c5a6a7

Browse files
committed
Resolving comments
1 parent c9be295 commit 8c5a6a7

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

examples/VariantAndAzureMonitorDemo/LoggerExtensions.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
using Microsoft.Extensions.Logging;
2-
3-
#nullable enable
4-
51
namespace VariantAndAzureMonitorDemo
62
{
73
public static class LoggerExtensions
@@ -15,6 +11,7 @@ public static class LoggerExtensions
1511
LogLevel.Information,
1612
new EventId(1, "microsoft.custom_event.name"),
1713
"{microsoft.custom_event.name} {success} {amount}");
14+
1815
public static void LogVote(this ILogger logger, int rating)
1916
{
2017
_vote(logger, "Vote", rating, null);

tests/Tests.FeatureManagement.Telemetry.AzureMonitor/ProcessorOrderTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,21 @@ public void TargetingProcessor_RunsBefore_Exporter()
2424
// 1. User adds OpenTelemetry and Exporter
2525
// Note: In a real app, UseAzureMonitor() would add the exporter.
2626
// We simulate this by adding a processor that acts as an exporter.
27+
var exportProcessor = new SimpleActivityExportProcessor(exporter);
2728
services.AddOpenTelemetry()
2829
.WithTracing(builder => builder
2930
.AddSource("TestTracer")
30-
.AddProcessor(new SimpleActivityExportProcessor(exporter)));
31+
.AddProcessor(exportProcessor));
3132

3233
// 2. User adds FeatureManagement and AzureMonitorTelemetry
3334
services.AddFeatureManagement()
3435
.AddAzureMonitorTelemetry();
3536

3637
using var serviceProvider = services.BuildServiceProvider();
3738
var tracerProvider = serviceProvider.GetRequiredService<TracerProvider>();
38-
var tracer = tracerProvider.GetTracer("TestTracer");
3939

4040
// 3. Start Activity with Baggage
41-
var source = new ActivitySource("TestTracer");
41+
using var source = new ActivitySource("TestTracer");
4242
using (var listener = new ActivityListener
4343
{
4444
ShouldListenTo = _ => true,
@@ -61,6 +61,8 @@ public void TargetingProcessor_RunsBefore_Exporter()
6161

6262
// If TargetingProcessor ran first, the tag should be present.
6363
Assert.Contains(tags, t => t.Key == "TargetingId" && t.Value == "User123");
64+
65+
exportProcessor.Dispose();
6466
}
6567

6668
private class InMemoryExporter : BaseExporter<Activity>

0 commit comments

Comments
 (0)