Skip to content

Commit 34e51b3

Browse files
authored
Skip op critical path benchmark test on FRS (all R11s actually) (#25570)
This test intentionally ignores server interactions (specifically it doesn't measure the op roundtrip time), so it shouldn't matter which service it runs against. We have seen some flakiness against FRS so drop that variant.
1 parent 8c1cba1 commit 34e51b3

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

packages/test/test-end-to-end-tests/src/test/benchmark/opCriticalPath.time.spec.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,13 @@ describeCompat(
5959

6060
let testId = 0;
6161

62+
beforeEach("check driver compatibility", function () {
63+
provider = getTestObjectProvider();
64+
if (provider.driver.type === "r11s" || provider.driver.type === "routerlicious") {
65+
this.skip(); // This test triggers 504 errors on AFR occasionally. The test intentionally ignores server interactions anyway.
66+
}
67+
});
68+
6269
const setup = async (): Promise<void> => {
6370
testId++;
6471
provider = getTestObjectProvider();
@@ -93,7 +100,8 @@ describeCompat(
93100
before: async () => {
94101
await setup();
95102
},
96-
benchmarkFnAsync: async () => {
103+
// eslint-disable-next-line object-shorthand
104+
benchmarkFnAsync: async function () {
97105
sendOps("A");
98106
// There's no event fired for "flush" so the simplest thing is to wait for the outbound queue to be idle.
99107
// This should not add much time, and is part of the real flow so it's ok to include it in the benchmark.

0 commit comments

Comments
 (0)