Skip to content

Commit 3b27b1b

Browse files
authored
fix(build-tools): allow Js builds to be incremental (#26807)
`allowJs` and `checkJs` were missing from the `incrementalOptions` list in `tscUtils.ts`. TypeScript stores these in `.tsbuildinfo`, but `filterIncrementalOptions()` stripped them from the config side only, causing a permanent mismatch that triggered a rebuild every time. Additionally fix two deficiencies from #10160 as suggest by Copilot review: - "useDefineForClassFields" was doubly defined and can be removed. - "skipdefaultlibcheck" was incorrectly cased, thus has not effect and can be removed.
1 parent a60e17d commit 3b27b1b

File tree

1 file changed

+2
-2
lines changed
  • build-tools/packages/build-tools/src/fluidBuild

1 file changed

+2
-2
lines changed

build-tools/packages/build-tools/src/fluidBuild/tscUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ const incrementalOptions = [
5959
"declarationDir",
6060
"useDefineForClassFields",
6161
"preserveValueImports",
62+
"allowJs",
6263

6364
// affectsSemanticDiagnostics === true
6465
"noImplicitAny",
@@ -83,13 +84,12 @@ const incrementalOptions = [
8384
"suppressExcessPropertyErrors",
8485
"suppressImplicitAnyIndexErrors",
8586
"noStrictGenericChecks",
86-
"useDefineForClassFields",
8787

8888
"skipLibCheck",
89-
"skipdefaultlibcheck",
9089
"strict",
9190
"strictBindCallApply",
9291
"strictFunctionTypes",
92+
"checkJs",
9393
].sort(); // sort it so that the result of the filter is sorted as well.
9494

9595
function filterIncrementalOptions(options: any): Record<string, unknown> {

0 commit comments

Comments
 (0)