test(directory): Update new SharedDirectory.forEach() test (#25303)

## Description

Follow up from #25299.
Updates the newly added test to ensure `forEach()` iterated the correct
number of times and uses `assert.equal` instead of `assert.strictEqual`.

Author: scottn12

packages/dds/map/src/test/mocha/directory.spec.ts

@@ -1064,18 +1064,21 @@ describe("Directory", () => {
 				// eslint-disable-next-line unicorn/no-array-for-each
 				directory1.forEach((value, key) => {
 					assert(i < values.length, "forEach() should not have iterated more than i times");
-					assert.strictEqual(key, values[i][0], "key should match");
-					assert.strictEqual(value, values[i][1], "value should match");
+					assert.equal(key, values[i][0], "key should match");
+					assert.equal(value, values[i][1], "value should match");
 					i++;
 				});
+				assert.equal(i, values.length, "forEach() should have iterated i times");
+
 				i = 0;
 				// eslint-disable-next-line unicorn/no-array-for-each
 				directory2.forEach((value, key) => {
 					assert(i < values.length, "forEach() should not have iterated more than i times");
-					assert.strictEqual(key, values[i][0], "key should match");
-					assert.strictEqual(value, values[i][1], "value should match");
+					assert.equal(key, values[i][0], "key should match");
+					assert.equal(value, values[i][1], "value should match");
 					i++;
 				});
+				assert.equal(i, values.length, "forEach() should have iterated i times");
 			});
 
 			it("Shouldn't clear value if there is pending set", () => {