improvement(eslint-config-fluid): Disable eslint rule that yields false positives (#26137)

Disables `unicorn/no-array-callback-reference`, which yields false
positives for non-array methods with the same name as array methods.

Author: Josmithr

common/build/eslint-config-fluid/CHANGELOG.md

@@ -74,6 +74,8 @@ Packages can now use `eslint.config.mjs` instead of `.eslintrc.cjs`, but the leg
 
 - `unicorn/import-style`: Changed from `"error"` to `"off"`
 - `unicorn/consistent-destructuring`: Changed from `"error"` to `"off"`
+- `unicorn/no-array-callback-reference`: Changed from `"error"` to `"off"`
+    - Yields false positives for calls to `map` methods on non-array types.
 
 **Unicorn rules changed to warnings** (to surface occurrences without breaking builds):
 

common/build/eslint-config-fluid/printed-configs/default.json

@@ -2050,7 +2050,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/printed-configs/react.json

@@ -2169,7 +2169,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/printed-configs/recommended.json

@@ -2050,7 +2050,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/printed-configs/strict-biome.json

@@ -2089,7 +2089,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/printed-configs/strict.json

@@ -2089,7 +2089,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/printed-configs/test.json

@@ -2046,7 +2046,7 @@
             "error"
         ],
         "unicorn/no-array-callback-reference": [
-            "error"
+            "off"
         ],
         "unicorn/no-array-for-each": [
             "error"

common/build/eslint-config-fluid/recommended.js

@@ -57,6 +57,9 @@ module.exports = {
 		// False positives on non-array `push` methods.
 		"unicorn/no-array-push-push": "off",
 
+		// False positives on non-array methods.
+		"unicorn/no-array-callback-reference": "off",
+
 		"unicorn/empty-brace-spaces": "off",
 
 		// Rationale: Destructuring of `Array.entries()` in order to get the index variable results in a

examples/benchmarks/bubblebench/ot/src/proxy/tree.ts

@@ -36,7 +36,7 @@ const arrayPatch = {
 			consumer(
 				item
 					.map((value, index) => json1.insertOp([...path, start + index], value))
-					// eslint-disable-next-line unicorn/no-array-reduce, unicorn/no-array-callback-reference
+					// eslint-disable-next-line unicorn/no-array-reduce
 					.reduce(json1.type.compose),
 			);
 			return target.push(...item);

packages/dds/map/src/directory.ts

@@ -525,7 +525,7 @@ export class SharedDirectory
 	// TODO: Use `unknown` instead (breaking change).
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any
 	public forEach(callback: (value: any, key: string, map: Map<string, any>) => void): void {
-		// eslint-disable-next-line unicorn/no-array-for-each, unicorn/no-array-callback-reference
+		// eslint-disable-next-line unicorn/no-array-for-each
 		this.root.forEach(callback);
 	}