Skip to content

Commit 573e20e

Browse files
authored
build(client): upgrade dependency-cruiser (#25705)
While testing #25687 I ran into a depcruiser build error like this: ``` @fluidframework/tree: error during command 'depcruise src/ --ignore-known' (exit code 1) @fluidframework/tree: file:///Volumes/Code/FluidFramework/node_modules/.pnpm/dependency-cruiser@14.1.2/node_modules/dependency-cruiser/src/cli/utl/assert-file-existence.mjs:1 @fluidframework/tree: import { accessSync, R_OK } from "node:fs"; @fluidframework/tree: ^^^^ @fluidframework/tree: SyntaxError: The requested module 'node:fs' does not provide an export named 'R_OK' @fluidframework/tree: at #_instantiate (node:internal/modules/esm/module_job:254:21) @fluidframework/tree: at async ModuleJob.run (node:internal/modules/esm/module_job:369:5) @fluidframework/tree: at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:689:26) @fluidframework/tree: at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:101:5) ``` It doesn't happen in CI, but when it happened locally I was able to fix it by upgrading to the latest version of dependency-cruiser. Despite the number of major versions, none of the breaking changes affect us as far as I can tell, so this seems to be a worthwhile upgrade regardless.
1 parent bef7f59 commit 573e20e

File tree

2 files changed

+85
-108
lines changed

2 files changed

+85
-108
lines changed

packages/dds/tree/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
"concurrently": "^8.2.1",
212212
"copyfiles": "^2.4.1",
213213
"cross-env": "^7.0.3",
214-
"dependency-cruiser": "^14.1.0",
214+
"dependency-cruiser": "^17.1.0",
215215
"diff": "^3.5.0",
216216
"easy-table": "^1.1.1",
217217
"eslint": "~8.57.1",

0 commit comments

Comments
 (0)