Skip to content

Commit 67c9f33

Browse files
fix: override serialize-javascript to patched version (#26819)
## Summary - Overrides `serialize-javascript@>=6 <7` to `^7.0.4` across all 13 workspaces to resolve a known security vulnerability - No 6.x patch exists; 7.x is API-compatible (only breaking change is Node.js >=20 requirement, which FluidFramework already meets) - Removes the now-redundant `mocha>serialize-javascript@6.0.0` scoped override in eslint-config-fluid (superseded by the broader override) - Consumers affected: terser-webpack-plugin, copy-webpack-plugin, mocha - Adds version-scoped override key to syncpack ignore list in build-tools - No code changes — config, lockfile, and override updates only ## Test plan - [x] CI passes across all workspace pipelines - [x] Link check passes (272,172 links, 0 errors) - [x] No functional changes — overrides only affect transitive dependency resolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent f2b0cf9 commit 67c9f33

File tree

27 files changed

+143
-225
lines changed

27 files changed

+143
-225
lines changed

build-tools/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@
156156
"mdast-util-to-hast: overridden to ^13.2.1 to fix a known vulnerability (unsanitized class attribute injection).",
157157
"simple-git: overridden to ^3.32.3 to resolve a CG alert.",
158158
"diff: overridden to patched versions to resolve a known ReDoS vulnerability. diff@7.x has no fix so it is bumped to 8.0.3.",
159-
"tar: overridden to ^7.5.11 to resolve multiple security vulnerabilities in tar 6.x (EOL, no backport)."
159+
"tar: overridden to ^7.5.11 to resolve multiple security vulnerabilities in tar 6.x (EOL, no backport).",
160+
"serialize-javascript: overridden to ^7.0.4 to resolve GHSA-5c6j-r48x-rmvq. No 6.x fix exists; 7.x is API-compatible (only drops Node <20 support)."
160161
],
161162
"overrides": {
162163
"@types/glob>@types/minimatch": "~5.1.2",
@@ -184,7 +185,8 @@
184185
"minimatch@>=7 <8": "^7.4.9",
185186
"minimatch@>=8 <9": "^8.0.7",
186187
"minimatch@>=9 <10": "^9.0.9",
187-
"minimatch@>=10 <11": "^10.2.4"
188+
"minimatch@>=10 <11": "^10.2.4",
189+
"serialize-javascript@>=6 <7": "^7.0.4"
188190
},
189191
"updateConfig": {
190192
"ignoreDependencies": [

build-tools/pnpm-lock.yaml

Lines changed: 7 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build-tools/syncpack.config.cjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ module.exports = {
9494
"minimatch@>=8 <9",
9595
"minimatch@>=9 <10",
9696
"minimatch@>=10 <11",
97+
"serialize-javascript@>=6 <7",
9798
"oclif>@aws-sdk/client*",
9899
"@types/glob>@types/minimatch",
99100
],

common/build/eslint-config-fluid/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,22 +78,22 @@
7878
},
7979
"pnpm": {
8080
"commentsOverrides": [
81-
"serialize-javascript - CVE-2024-11831 impacts version 6.0.0 which is pinned by mocha 10.4.0, which in turn comes from mocha-multi-reporters 1.5.1 (which has no updated version at this time)",
8281
"js-yaml: overridden to fix CVE-2025-64718 (prototype pollution via merge keys).",
8382
"diff: overridden to patched version to resolve a known ReDoS vulnerability.",
84-
"minimatch: overridden to patched versions to resolve known security vulnerabilities across all major version ranges."
83+
"minimatch: overridden to patched versions to resolve known security vulnerabilities across all major version ranges.",
84+
"serialize-javascript: overridden to ^7.0.4 to resolve GHSA-5c6j-r48x-rmvq and CVE-2024-11831. No 6.x fix exists; 7.x is API-compatible (only drops Node <20 support)."
8585
],
8686
"overrides": {
8787
"diff@>=5 <6": "^5.2.2",
8888
"js-yaml": "^4.1.1",
89-
"mocha>serialize-javascript@6.0.0": "^6.0.2",
9089
"minimatch@>=3 <4": "^3.1.5",
9190
"minimatch@>=5 <6": "^5.1.9",
9291
"minimatch@>=6 <7": "^6.2.3",
9392
"minimatch@>=7 <8": "^7.4.9",
9493
"minimatch@>=8 <9": "^8.0.7",
9594
"minimatch@>=9 <10": "^9.0.9",
96-
"minimatch@>=10 <11": "^10.2.4"
95+
"minimatch@>=10 <11": "^10.2.4",
96+
"serialize-javascript@>=6 <7": "^7.0.4"
9797
},
9898
"onlyBuiltDependencies": [
9999
"esbuild",

common/build/eslint-config-fluid/pnpm-lock.yaml

Lines changed: 6 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/build/eslint-plugin-fluid/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@
5454
"qs: overridden to ^6.15.0 to resolve a known vulnerability in older versions.",
5555
"js-yaml: overridden to fix CVE-2025-64718 (prototype pollution via merge keys).",
5656
"diff: overridden to patched version to resolve a known ReDoS vulnerability.",
57-
"minimatch: overridden to patched versions to resolve known security vulnerabilities across all major version ranges."
57+
"minimatch: overridden to patched versions to resolve known security vulnerabilities across all major version ranges.",
58+
"serialize-javascript: overridden to ^7.0.4 to resolve GHSA-5c6j-r48x-rmvq. No 6.x fix exists; 7.x is API-compatible (only drops Node <20 support)."
5859
],
5960
"overrides": {
6061
"diff@>=5 <6": "^5.2.2",
@@ -67,7 +68,8 @@
6768
"minimatch@>=7 <8": "^7.4.9",
6869
"minimatch@>=8 <9": "^8.0.7",
6970
"minimatch@>=9 <10": "^9.0.9",
70-
"minimatch@>=10 <11": "^10.2.4"
71+
"minimatch@>=10 <11": "^10.2.4",
72+
"serialize-javascript@>=6 <7": "^7.0.4"
7173
}
7274
}
7375
}

common/build/eslint-plugin-fluid/pnpm-lock.yaml

Lines changed: 6 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/lib/common-utils/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@
159159
"js-yaml: overridden to fix a known vulnerability (prototype pollution via merge keys).",
160160
"simple-git: overridden to ^3.32.3 to resolve a CG alert.",
161161
"diff: overridden to patched versions to resolve a known ReDoS vulnerability.",
162-
"tar: overridden to ^7.5.11 to resolve multiple security vulnerabilities in tar 6.x (EOL, no backport)."
162+
"tar: overridden to ^7.5.11 to resolve multiple security vulnerabilities in tar 6.x (EOL, no backport).",
163+
"serialize-javascript: overridden to ^7.0.4 to resolve GHSA-5c6j-r48x-rmvq. No 6.x fix exists; 7.x is API-compatible (only drops Node <20 support)."
163164
],
164165
"overrides": {
165166
"diff@>=4 <5": "^4.0.4",
@@ -180,7 +181,8 @@
180181
"minimatch@>=7 <8": "^7.4.9",
181182
"minimatch@>=8 <9": "^8.0.7",
182183
"minimatch@>=9 <10": "^9.0.9",
183-
"minimatch@>=10 <11": "^10.2.4"
184+
"minimatch@>=10 <11": "^10.2.4",
185+
"serialize-javascript@>=6 <7": "^7.0.4"
184186
},
185187
"patchedDependencies": {
186188
"@microsoft/api-extractor@7.52.11": "../../../patches/@microsoft__api-extractor@7.52.11.patch"

common/lib/common-utils/pnpm-lock.yaml

Lines changed: 7 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)