Skip to content

Commit a33a2e3

Browse files
agarwal-navinagarwal-navin
authored
(op bunching) Removed deprecated property processCore from SharedObject (#25749)
## Description Removed deprecated property `processCore` from `SharedObject` and all its implementations. ## Breaking Changes This is a breaking change. The deprecations were announced in release [2.22.0](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.22.0).
1 parent 32cc2c7 commit a33a2e3

File tree

29 files changed

+60
-544
lines changed

29 files changed

+60
-544
lines changed

‎.changeset/silver-cobras-jam.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"@fluidframework/ordered-collection": minor
3+
"@fluidframework/register-collection": minor
4+
"@fluidframework/shared-object-base": minor
5+
"__section": breaking
6+
---
7+
Deprecated property processCore has been removed from SharedObject
8+
9+
The deprecated property `processCore` has been removed from `SharedObject`.
10+
11+
Please see [this github issue](https://github.com/microsoft/FluidFramework/issues/25176) for more details.

‎experimental/PropertyDDS/packages/property-dds/src/propertyTree.ts‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -363,18 +363,6 @@ export class SharedPropertyTree extends SharedObject {
363363
this._root._reportDirtinessToView();
364364
}
365365

366-
protected processCore(
367-
message: ISequencedDocumentMessage,
368-
local: boolean,
369-
localOpMetadata: unknown,
370-
): void {
371-
this.processMessage(message, {
372-
contents: message.contents,
373-
localOpMetadata,
374-
clientSequenceNumber: message.clientSequenceNumber,
375-
});
376-
}
377-
378366
/**
379367
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
380368
*/

‎experimental/dds/ot/ot/src/ot.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {
1010
IFluidDataStoreRuntime,
1111
IChannelStorageService,
1212
} from "@fluidframework/datastore-definitions/internal";
13-
import type { ISequencedDocumentMessage } from "@fluidframework/driver-definitions/internal";
1413
import {
1514
ISummaryTreeWithStats,
1615
type IRuntimeMessageCollection,
@@ -108,22 +107,6 @@ export abstract class SharedOT<TState, TOp> extends SharedObject {
108107

109108
protected onDisconnect() {}
110109

111-
protected processCore(
112-
message: ISequencedDocumentMessage,
113-
local: boolean,
114-
localOpMetadata: unknown,
115-
): void {
116-
this.processMessage(
117-
message,
118-
{
119-
contents: message.contents,
120-
localOpMetadata,
121-
clientSequenceNumber: message.clientSequenceNumber,
122-
},
123-
local,
124-
);
125-
}
126-
127110
/**
128111
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
129112
*/

‎experimental/dds/tree/api-report/experimental-tree.alpha.api.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,6 @@ export class SharedTree extends SharedObject<ISharedTreeEvents> implements NodeI
668668
get logViewer(): LogViewer;
669669
mergeEditsFrom(other: SharedTree, edits: Iterable<Edit<InternalizedChange>>, stableIdRemapper?: (id: StableNodeId) => StableNodeId): EditId[];
670670
protected onDisconnect(): void;
671-
protected processCore(message: unknown, local: boolean): void;
672671
protected processMessagesCore(messagesCollection: IRuntimeMessageCollection): void;
673672
protected registerCore(): void;
674673
// (undocumented)

‎experimental/dds/tree/src/SharedTree.ts‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
IChannelServices,
1515
IChannelStorageService,
1616
} from '@fluidframework/datastore-definitions/internal';
17-
import { ISequencedDocumentMessage } from '@fluidframework/driver-definitions/internal';
1817
import {
1918
ISummaryTreeWithStats,
2019
ITelemetryContext,
@@ -999,14 +998,6 @@ export class SharedTree extends SharedObject<ISharedTreeEvents> implements NodeI
999998
}
1000999
}
10011000

1002-
/**
1003-
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processCore}
1004-
*/
1005-
protected processCore(message: unknown, local: boolean): void {
1006-
const typedMessage = message as ISequencedDocumentMessage;
1007-
this.processMessage(typedMessage, typedMessage.contents);
1008-
}
1009-
10101001
/**
10111002
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
10121003
*/

‎packages/dds/cell/src/cell.ts‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import type {
1010
Serializable,
1111
IChannelStorageService,
1212
} from "@fluidframework/datastore-definitions/internal";
13-
import {
14-
MessageType,
15-
type ISequencedDocumentMessage,
16-
} from "@fluidframework/driver-definitions/internal";
13+
import { MessageType } from "@fluidframework/driver-definitions/internal";
1714
import { readAndParse } from "@fluidframework/driver-utils/internal";
1815
import type {
1916
ISummaryTreeWithStats,
@@ -245,22 +242,6 @@ export class SharedCell<T = any>
245242
}
246243
}
247244

248-
protected processCore(
249-
message: ISequencedDocumentMessage,
250-
local: boolean,
251-
localOpMetadata: unknown,
252-
): void {
253-
this.processMessage(
254-
message,
255-
{
256-
contents: message.contents,
257-
localOpMetadata,
258-
clientSequenceNumber: message.clientSequenceNumber,
259-
},
260-
local,
261-
);
262-
}
263-
264245
/**
265246
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
266247
*/

‎packages/dds/counter/src/counter.ts‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ import type {
99
IFluidDataStoreRuntime,
1010
IChannelStorageService,
1111
} from "@fluidframework/datastore-definitions/internal";
12-
import {
13-
MessageType,
14-
type ISequencedDocumentMessage,
15-
} from "@fluidframework/driver-definitions/internal";
12+
import { MessageType } from "@fluidframework/driver-definitions/internal";
1613
import { readAndParse } from "@fluidframework/driver-utils/internal";
1714
import type {
1815
ISummaryTreeWithStats,
@@ -126,22 +123,6 @@ export class SharedCounter
126123
*/
127124
protected onDisconnect(): void {}
128125

129-
protected processCore(
130-
message: ISequencedDocumentMessage,
131-
local: boolean,
132-
localOpMetadata: unknown,
133-
): void {
134-
this.processMessage(
135-
message,
136-
{
137-
contents: message.contents,
138-
localOpMetadata,
139-
clientSequenceNumber: message.clientSequenceNumber,
140-
},
141-
local,
142-
);
143-
}
144-
145126
/**
146127
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
147128
*/

‎packages/dds/ink/src/ink.ts‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ import type {
88
IFluidDataStoreRuntime,
99
IChannelStorageService,
1010
} from "@fluidframework/datastore-definitions/internal";
11-
import {
12-
MessageType,
13-
type ISequencedDocumentMessage,
14-
} from "@fluidframework/driver-definitions/internal";
11+
import { MessageType } from "@fluidframework/driver-definitions/internal";
1512
import { readAndParse } from "@fluidframework/driver-utils/internal";
1613
import type {
1714
ISummaryTreeWithStats,
@@ -212,25 +209,6 @@ export class Ink extends SharedObject<IInkEvents> implements IInk {
212209
this.inkData = new InkData(content);
213210
}
214211

215-
/**
216-
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processCore}
217-
*/
218-
protected processCore(
219-
message: ISequencedDocumentMessage,
220-
local: boolean,
221-
localOpMetadata: unknown,
222-
): void {
223-
this.processMessage(
224-
message,
225-
{
226-
contents: message.contents,
227-
localOpMetadata,
228-
clientSequenceNumber: message.clientSequenceNumber,
229-
},
230-
local,
231-
);
232-
}
233-
234212
/**
235213
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
236214
*/

‎packages/dds/legacy-dds/src/array/sharedArray.ts‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@ import type {
1111
IChannelFactory,
1212
IChannelStorageService,
1313
} from "@fluidframework/datastore-definitions/internal";
14-
import type {
15-
ISequencedDocumentMessage,
16-
ITree,
17-
} from "@fluidframework/driver-definitions/internal";
14+
import type { ITree } from "@fluidframework/driver-definitions/internal";
1815
import { FileMode, MessageType, TreeEntry } from "@fluidframework/driver-definitions/internal";
1916
import type {
2017
ISummaryTreeWithStats,
@@ -563,22 +560,6 @@ export class SharedArrayClass<T extends SerializableTypeForSharedArray>
563560
return this.idToEntryMap.get(entryId) as SharedArrayEntry<T>;
564561
}
565562

566-
protected processCore(
567-
message: ISequencedDocumentMessage,
568-
local: boolean,
569-
localOpMetadata: unknown,
570-
): void {
571-
this.processMessage(
572-
message,
573-
{
574-
contents: message.contents,
575-
localOpMetadata,
576-
clientSequenceNumber: message.clientSequenceNumber,
577-
},
578-
local,
579-
);
580-
}
581-
582563
/**
583564
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
584565
*/

‎packages/dds/legacy-dds/src/signal/sharedSignal.ts‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ import type {
1212
IChannelFactory,
1313
} from "@fluidframework/datastore-definitions/internal";
1414
import { FileMode, MessageType, TreeEntry } from "@fluidframework/driver-definitions/internal";
15-
import type {
16-
ISequencedDocumentMessage,
17-
ITree,
18-
} from "@fluidframework/driver-definitions/internal";
15+
import type { ITree } from "@fluidframework/driver-definitions/internal";
1916
import type {
2017
ISummaryTreeWithStats,
2118
IRuntimeMessageCollection,
@@ -135,22 +132,6 @@ export class SharedSignalClass<T extends SerializableTypeForSharedSignal = any>
135132
*/
136133
protected onDisconnect(): void {}
137134

138-
protected processCore(
139-
message: ISequencedDocumentMessage,
140-
local: boolean,
141-
localOpMetadata: unknown,
142-
): void {
143-
this.processMessage(
144-
message,
145-
{
146-
contents: message.contents,
147-
localOpMetadata,
148-
clientSequenceNumber: message.clientSequenceNumber,
149-
},
150-
local,
151-
);
152-
}
153-
154135
/**
155136
* {@inheritDoc @fluidframework/shared-object-base#SharedObject.processMessagesCore}
156137
*/

0 commit comments

Comments
 (0)