Skip to content

Commit dabfc53

Browse files
tylerbutlertylerbutler
authored
build(eslint-config-fluid): restore as independent workspace (#26427)
## Summary Reverses #25806 which temporarily moved `@fluidframework/eslint-config-fluid` into the client release group. The package is restored as an independently versioned workspace at **v9.0.0**, preparing it for its next published release with ESLint 9 flat config support. ### Key changes - **eslint-config-fluid**: Version set to `9.0.0`, removed `private: true`, removed `typeValidation` block in package.json. All ESLint 9 work (flat config, typescript-eslint 8.54, etc.) is preserved. - **pnpm-workspace.yaml**: Package removed from workspace members. Added an `eslint` catalog group for `eslint`, `eslint-config-prettier`, and `@fluid-internal/eslint-config-fluid`. - **Root package.json**: Uses `link:` protocol with a pnpm override to resolve references across the workspace, plus a `postinstall` script to install transitive deps. ESLint version moved to `catalog:eslint`. - **Client packages**: Dependencies changed from `workspace:~` to `catalog:eslint` for `eslint-config-fluid`, `eslint`, and `eslint-config-prettier`. - **fluidBuild.config.cjs**: Removed temporary `npm-private-packages` policy exclusion; added `npm-package-types-field` exclusion. - **syncpack.config.cjs**: Added ignore rules for `eslint-config-fluid` (link: protocol is unresolvable by syncpack). - **build-eslint-config-fluid.yml**: Re-enabled `taskPack` for publishing.
1 parent b77334f commit dabfc53

File tree

169 files changed

+1185
-2324
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

169 files changed

+1185
-2324
lines changed

‎PACKAGES.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ The dependencies between layers are enforced by the layer-check command._
111111

112112
| Packages | Layer Dependencies |
113113
| --- | --- |
114-
| - [@fluidframework/build-common](/common/build/build-common)</br>- [@fluidframework/eslint-config-fluid](/common/build/eslint-config-fluid) (private)</br>- [@fluid-internal/eslint-plugin-fluid](/common/build/eslint-plugin-fluid)</br>- [@fluid-tools/benchmark](/tools/benchmark) | &nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; |
114+
| - [@fluidframework/build-common](/common/build/build-common)</br>- [@fluidframework/eslint-config-fluid](/common/build/eslint-config-fluid)</br>- [@fluid-internal/eslint-plugin-fluid](/common/build/eslint-plugin-fluid)</br>- [@fluid-tools/benchmark](/tools/benchmark) | &nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; |
115115

116116
### AzureClient
117117

‎azure/packages/azure-local-service/package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
"@biomejs/biome": "~2.4.5",
3535
"@fluidframework/build-common": "^2.0.3",
3636
"@fluidframework/build-tools": "catalog:buildTools",
37-
"@fluidframework/eslint-config-fluid": "workspace:~",
38-
"eslint": "~9.39.1",
39-
"eslint-config-prettier": "~10.1.8",
37+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
38+
"eslint": "catalog:eslint",
39+
"eslint-config-prettier": "catalog:eslint",
4040
"jiti": "^2.6.1",
4141
"pm2": "^5.4.2",
4242
"rimraf": "^6.1.3"

‎azure/packages/azure-service-utils/package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@
9898
"@fluidframework/azure-service-utils-previous": "npm:@fluidframework/azure-service-utils@2.83.0",
9999
"@fluidframework/build-common": "^2.0.3",
100100
"@fluidframework/build-tools": "catalog:buildTools",
101-
"@fluidframework/eslint-config-fluid": "workspace:~",
101+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
102102
"@microsoft/api-extractor": "7.52.11",
103103
"@types/jsrsasign": "^10.5.12",
104104
"concurrently": "^9.2.1",
105105
"copyfiles": "^2.4.1",
106-
"eslint": "~9.39.1",
107-
"eslint-config-prettier": "~10.1.8",
106+
"eslint": "catalog:eslint",
107+
"eslint-config-prettier": "catalog:eslint",
108108
"jiti": "^2.6.1",
109109
"rimraf": "^6.1.3",
110110
"typescript": "~5.4.5"

‎common/build/eslint-config-fluid/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ a diff to review as part of a PR -- just like we do with API reports for code ch
103103
|--------|-------------|
104104
| `build` | `npm run print-config` |
105105
| `build:readme:disabled` | `markdown-magic --files "**/*.md"` |
106-
| `clean` | `rimraf --glob dist` |
106+
| `clean` | `rimraf --glob dist "**/*.build.log"` |
107107
| `format` | `npm run prettier:fix` |
108108
| `prettier` | `prettier --check .` |
109109
| `prettier:fix` | `prettier --write .` |

‎common/build/eslint-config-fluid/package.json‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"name": "@fluidframework/eslint-config-fluid",
3-
"version": "2.92.0",
4-
"private": true,
3+
"version": "9.0.0",
54
"description": "Shareable ESLint config for the Fluid Framework",
65
"homepage": "https://fluidframework.com",
76
"repository": {
@@ -99,8 +98,5 @@
9998
"esbuild",
10099
"unrs-resolver"
101100
]
102-
},
103-
"typeValidation": {
104-
"disabled": true
105101
}
106102
}

‎examples/apps/blobs/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@
6666
"@fluid-tools/build-cli": "catalog:buildTools",
6767
"@fluidframework/build-common": "^2.0.3",
6868
"@fluidframework/build-tools": "catalog:buildTools",
69-
"@fluidframework/eslint-config-fluid": "workspace:~",
69+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
7070
"@fluidframework/test-tools": "^2.0.0",
7171
"@types/jest": "29.5.3",
7272
"@types/jest-environment-puppeteer": "workspace:~",
7373
"@types/node": "~20.19.30",
7474
"@types/react": "^18.3.11",
7575
"@types/react-dom": "^18.3.0",
7676
"cross-env": "^10.1.0",
77-
"eslint": "~9.39.1",
77+
"eslint": "catalog:eslint",
7878
"expect-puppeteer": "^9.0.2",
7979
"html-webpack-plugin": "^5.6.0",
8080
"jest": "^29.6.2",

‎examples/apps/collaborative-textarea/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"@fluid-tools/build-cli": "catalog:buildTools",
6262
"@fluidframework/build-common": "^2.0.3",
6363
"@fluidframework/build-tools": "catalog:buildTools",
64-
"@fluidframework/eslint-config-fluid": "workspace:~",
64+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
6565
"@fluidframework/test-tools": "^2.0.0",
6666
"@fluidframework/test-utils": "workspace:~",
6767
"@types/jest": "29.5.3",
@@ -70,7 +70,7 @@
7070
"@types/react": "^18.3.11",
7171
"@types/react-dom": "^18.3.0",
7272
"cross-env": "^10.1.0",
73-
"eslint": "~9.39.1",
73+
"eslint": "catalog:eslint",
7474
"expect-puppeteer": "^9.0.2",
7575
"html-webpack-plugin": "^5.6.0",
7676
"jest": "^29.6.2",

‎examples/apps/contact-collection/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@
5353
"@fluid-tools/build-cli": "catalog:buildTools",
5454
"@fluidframework/build-common": "^2.0.3",
5555
"@fluidframework/build-tools": "catalog:buildTools",
56-
"@fluidframework/eslint-config-fluid": "workspace:~",
56+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
5757
"@fluidframework/test-tools": "^2.0.0",
5858
"@types/jest": "29.5.3",
5959
"@types/jest-environment-puppeteer": "workspace:~",
6060
"@types/node": "~20.19.30",
6161
"@types/react": "^18.3.11",
6262
"@types/react-dom": "^18.3.0",
6363
"cross-env": "^10.1.0",
64-
"eslint": "~9.39.1",
64+
"eslint": "catalog:eslint",
6565
"expect-puppeteer": "^9.0.2",
6666
"html-webpack-plugin": "^5.6.0",
6767
"jest": "^29.6.2",

‎examples/apps/data-object-grid/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"@fluid-tools/build-cli": "catalog:buildTools",
6868
"@fluidframework/build-common": "^2.0.3",
6969
"@fluidframework/build-tools": "catalog:buildTools",
70-
"@fluidframework/eslint-config-fluid": "workspace:~",
70+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
7171
"@fluidframework/test-tools": "^2.0.0",
7272
"@types/jest": "29.5.3",
7373
"@types/jest-environment-puppeteer": "workspace:~",
@@ -79,7 +79,7 @@
7979
"copyfiles": "^2.4.1",
8080
"cross-env": "^10.1.0",
8181
"css-loader": "^7.1.2",
82-
"eslint": "~9.39.1",
82+
"eslint": "catalog:eslint",
8383
"expect-puppeteer": "^9.0.2",
8484
"html-loader": "^5.1.0",
8585
"html-webpack-plugin": "^5.6.0",

‎examples/apps/diceroller/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,14 @@
5353
"@fluid-tools/build-cli": "catalog:buildTools",
5454
"@fluidframework/build-common": "^2.0.3",
5555
"@fluidframework/build-tools": "catalog:buildTools",
56-
"@fluidframework/eslint-config-fluid": "workspace:~",
56+
"@fluidframework/eslint-config-fluid": "catalog:eslint",
5757
"@fluidframework/test-tools": "^2.0.0",
5858
"@types/jest": "29.5.3",
5959
"@types/jest-environment-puppeteer": "workspace:~",
6060
"@types/node": "~20.19.30",
6161
"@types/react": "^18.3.11",
6262
"cross-env": "^10.1.0",
63-
"eslint": "~9.39.1",
63+
"eslint": "catalog:eslint",
6464
"expect-puppeteer": "^9.0.2",
6565
"html-webpack-plugin": "^5.6.0",
6666
"jest": "^29.6.2",

0 commit comments

Comments
 (0)