Change flag name to DisableCloseOnAttachFailure

Author: kian-thompson

packages/common/container-definitions/src/loader.ts

@@ -421,7 +421,7 @@ export interface IContainer extends IEventProvider<IContainerEvents> {
 	 *
 	 * By default, the container will close if attach fails.
 	 * However, closure can now be avoided in most cased by setting:
-	 * Fluid.Container.RetryOnAttachFailure to true
+	 * Fluid.Container.DisableCloseOnAttachFailure to true
 	 * via the config provider passed to the loader.
 	 *
 	 * If attach fails, check the closed property to discover if retry is possible.

packages/loader/container-loader/src/container.ts

@@ -1301,7 +1301,9 @@ export class Container
 					});
 
 					// only enable the new behavior if the config is set
-					if (this.mc.config.getBoolean("Fluid.Container.RetryOnAttachFailure") !== true) {
+					if (
+						this.mc.config.getBoolean("Fluid.Container.DisableCloseOnAttachFailure") !== true
+					) {
 						attachP = attachP.catch((error) => {
 							throw normalizeErrorAndClose(error);
 						});
@@ -1547,11 +1549,11 @@ export class Container
 				service.on("metadataUpdate", this.metadataUpdateHandler);
 			}
 		} else {
-			// When RetryOnAttachFailure is enabled, use no internal retries
+			// When DisableCloseOnAttachFailure is enabled, use no internal retries
 			// The consumer will own the retry policy
-			const retryOnAttachFailure =
-				this.mc.config.getBoolean("Fluid.Container.RetryOnAttachFailure") === true;
-			const maxRetries = retryOnAttachFailure ? 0 : undefined;
+			const disableCloseOnAttachFailure =
+				this.mc.config.getBoolean("Fluid.Container.DisableCloseOnAttachFailure") === true;
+			const maxRetries = disableCloseOnAttachFailure ? 0 : undefined;
 
 			service = await runWithRetry(
 				async () =>

packages/loader/container-loader/src/test/loader.spec.ts

@@ -98,7 +98,7 @@ describe("loader unit test", () => {
 			urlResolver: failProxy(),
 			configProvider: {
 				getRawConfig: (name): ConfigTypes =>
-					name === "Fluid.Container.RetryOnAttachFailure" ? true : undefined,
+					name === "Fluid.Container.DisableCloseOnAttachFailure" ? true : undefined,
 			},
 		});
 		const detached = await loader.createDetachedContainer({ package: "none" });
@@ -136,7 +136,7 @@ describe("loader unit test", () => {
 			}),
 			configProvider: {
 				getRawConfig: (name): ConfigTypes =>
-					name === "Fluid.Container.RetryOnAttachFailure" ? true : undefined,
+					name === "Fluid.Container.DisableCloseOnAttachFailure" ? true : undefined,
 			},
 		});
 		const detached = await loader.createDetachedContainer({ package: "none" });

packages/test/test-end-to-end-tests/src/test/blobs.spec.ts

@@ -583,7 +583,7 @@ function serializationTests({
 					loaderProps: {
 						documentServiceFactory,
 						configProvider: createTestConfigProvider({
-							"Fluid.Container.RetryOnAttachFailure": true,
+							"Fluid.Container.DisableCloseOnAttachFailure": true,
 						}),
 					},
 				});

packages/test/test-end-to-end-tests/src/test/detachedContainerTests.spec.ts

@@ -956,7 +956,7 @@ describeCompat("Detached Container", "NoCompat", (getTestObjectProvider, apis) =
 				{
 					configProvider: {
 						getRawConfig: (name) =>
-							name === "Fluid.Container.RetryOnAttachFailure" ? true : undefined,
+							name === "Fluid.Container.DisableCloseOnAttachFailure" ? true : undefined,
 					},
 				},
 			);

packages/test/test-end-to-end-tests/src/test/serializeAfterFailedAttach.spec.ts

@@ -87,7 +87,7 @@ describeCompat(
 				logger: provider.logger,
 				configProvider: {
 					getRawConfig: (name) =>
-						name === "Fluid.Container.RetryOnAttachFailure" ? true : undefined,
+						name === "Fluid.Container.DisableCloseOnAttachFailure" ? true : undefined,
 				},
 			});
 			return testLoader;