Skip to content

Commit f3717b1

Browse files
Abe27342Abram Sanderson
andauthored
Only update manifest if at least one publishing stage succeeded (#25297)
## Description Some recent CI runs have not published any packages due to flaky tests. However, the manifest upload step was still happening due to this incorrect condition. Co-authored-by: Abram Sanderson <[email protected]>
1 parent 6bc5072 commit f3717b1

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

tools/pipelines/templates/include-publish-npm-package.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,12 @@ stages:
126126
and(
127127
in(dependencies.publish_npm_public.result, 'Succeeded', 'Skipped'),
128128
in(dependencies.publish_npm_internal_test.result, 'Succeeded', 'Skipped'),
129-
in(dependencies.publish_npm_internal_build.result, 'Succeeded', 'Skipped')
129+
in(dependencies.publish_npm_internal_build.result, 'Succeeded', 'Skipped'),
130+
or(
131+
eq(dependencies.publish_npm_public.result, 'Succeeded'),
132+
eq(dependencies.publish_npm_internal_test.result, 'Succeeded'),
133+
eq(dependencies.publish_npm_internal_build.result, 'Succeeded')
134+
)
130135
)
131136
# Note dev feed packages do not get manifests as we don't intend them to be consumed publicly, so no need for that to be a dependency here.
132137
variables:

0 commit comments

Comments
 (0)