SDK: Always match by id first (#255)

* match by id first

* remnant

Author: jambayk

sdk/cs/src/FoundryLocalManager.cs

@@ -150,18 +150,17 @@ public void RefreshCatalog()
 
     public async Task<ModelInfo?> GetModelInfoAsync(string aliasOrModelId, DeviceType? device = null, CancellationToken ct = default)
     {
-        // Resolve directly from the cached list (mirrors Python behavior)
         var catalog = await ListCatalogModelsAsync(ct);
         if (catalog.Count == 0 || string.IsNullOrWhiteSpace(aliasOrModelId))
         {
             return null;
         }
 
-        // 1) If looks like a full ID (has ':'), match by ID exactly
-        if (aliasOrModelId.Contains(':'))
+        // 1) Try to match by full ID exactly (with or without ':' for backwards compatibility)
+        var exact = catalog.FirstOrDefault(m =>
+            m.ModelId.Equals(aliasOrModelId, StringComparison.OrdinalIgnoreCase));
+        if (exact != null)
         {
-            var exact = catalog.FirstOrDefault(m =>
-                m.ModelId.Equals(aliasOrModelId, StringComparison.OrdinalIgnoreCase));
             return exact;
         }
 
@@ -193,7 +192,7 @@ public void RefreshCatalog()
             aliasMatches = aliasMatches.Where(m => m.Runtime.DeviceType == device);
         }
 
-        // Catalog/list is assumed pre-sorted by service similar to Python comment:
+        // Catalog/list is assumed pre-sorted by service:
         // NPU → non-generic-GPU → generic-GPU → non-generic-CPU → CPU
         var candidate = aliasMatches.FirstOrDefault();
         if (candidate == null) return null;

sdk/js/src/base.ts

@@ -157,16 +157,10 @@ export class FoundryLocalManager {
     const catalog = await this.listCatalogModels()
     const key = aliasOrModelId.toLowerCase()
 
-    // 1) Full ID with version
-    if (aliasOrModelId.includes(':')) {
-      const exact = catalog.find((m) => m.id.toLowerCase() === key)
-      if (exact) {
-        return exact
-      }
-      if (throwOnNotFound) {
-        throw new Error(`Model ${aliasOrModelId} not found in the catalog.`)
-      }
-      return null
+    // 1) Full ID match (with or without ':' for backwards compatibility)
+    const exact = catalog.find((m) => m.id.toLowerCase() === key)
+    if (exact) {
+      return exact
     }
 
     // 2) ID prefix → pick highest version

sdk/python/foundry_local/api.py

@@ -182,14 +182,10 @@ def get_model_info(
         catalog = self.list_catalog_models()
         key = alias_or_model_id.lower()
 
-        # 1) If it looks like a full ID (has ':'), match by ID exactly
-        if ":" in alias_or_model_id:
-            model_info = next((m for m in catalog if m.id.lower() == key), None)
-            if model_info is not None:
-                return model_info
-            if raise_on_not_found:
-                raise ValueError(f"Model {alias_or_model_id} not found in the catalog.")
-            return None
+        # 1) Try to match by full ID exactly (with or without ':' for backwards compatibility)
+        model_info = next((m for m in catalog if m.id.lower() == key), None)
+        if model_info is not None:
+            return model_info
 
         # 2) Try to match by ID prefix "<id>:" and pick the highest version
         prefix = f"{key}:"