Skip to content

Commit a4d4d95

Browse files
committed
fix(pr-1092): address new copilot review threads
- narrow azure-prepare trigger wording to avoid migration overlap\n- make fallback wording provider-scoped in iac-rules\n- update azure-prepare trigger snapshots\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent ee9559c commit a4d4d95

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

plugin/skills/azure-prepare/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: azure-prepare
3-
description: "Prepare applications for Azure deployment, except cross-cloud migration (use azure-cloud-migrate). Generates or updates azure.yaml, infrastructure (Bicep/Terraform), and Dockerfiles. WHEN: \"prepare app for Azure\", \"build web app and host on Azure\", \"migrate application to Azure\", \"configure Azure hosting\", \"create Azure app\", \"add Azure service\", \"modernize app for Azure\", \"generate azure.yaml\", \"generate Bicep\", \"generate Terraform\", \"create Azure Functions app\"."
3+
description: "Prepare applications for Azure deployment, except cross-cloud scenarios (use azure-cloud-migrate). Generates or updates azure.yaml, infrastructure (Bicep/Terraform), and Dockerfiles. WHEN: \"prepare app for Azure\", \"build web app and host on Azure\", \"move on-premises application to Azure\", \"configure Azure hosting\", \"create Azure app\", \"add Azure service\", \"modernize app for Azure\", \"generate azure.yaml\", \"generate Bicep\", \"generate Terraform\", \"create Azure Functions app\"."
44
---
55

66
# Azure Prepare

plugin/skills/azure-prepare/references/recipes/azd/iac-rules.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ For **Terraform**:
1616
2. AVM Terraform Resource Modules
1717
3. AVM Terraform Utility Modules
1818

19-
If no AVM+AZD pattern module exists for the scenario, default immediately to AVM modules in the same order (resource, then utility) instead of using non-AVM modules.
19+
If no pattern module exists for the active provider, default immediately to AVM modules in the same provider order (resource, then utility) instead of using non-AVM modules.
2020

2121
## Retrieval Strategy (Hybrid: azure-documentation MCP + Context7)
2222

tests/azure-prepare/__snapshots__/triggers.test.ts.snap

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
exports[`azure-prepare - Trigger Tests Trigger Keywords Snapshot skill description triggers match snapshot 1`] = `
44
{
5-
"description": "Prepare applications for Azure deployment, except cross-cloud migration (use azure-cloud-migrate). Generates or updates azure.yaml, infrastructure (Bicep/Terraform), and Dockerfiles. WHEN: "prepare app for Azure", "build web app and host on Azure", "migrate application to Azure", "configure Azure hosting", "create Azure app", "add Azure service", "modernize app for Azure", "generate azure.yaml", "generate Bicep", "generate Terraform", "create Azure Functions app".",
5+
"description": "Prepare applications for Azure deployment, except cross-cloud scenarios (use azure-cloud-migrate). Generates or updates azure.yaml, infrastructure (Bicep/Terraform), and Dockerfiles. WHEN: "prepare app for Azure", "build web app and host on Azure", "move on-premises application to Azure", "configure Azure hosting", "create Azure app", "add Azure service", "modernize app for Azure", "generate azure.yaml", "generate Bicep", "generate Terraform", "create Azure Functions app".",
66
"extractedKeywords": [
77
"application",
88
"applications",
@@ -26,10 +26,11 @@ exports[`azure-prepare - Trigger Tests Trigger Keywords Snapshot skill descripti
2626
"hosting",
2727
"identity",
2828
"infrastructure",
29-
"migrate",
30-
"migration",
3129
"modernize",
30+
"move",
31+
"on-premises",
3232
"prepare",
33+
"scenarios",
3334
"security",
3435
"service",
3536
"terraform",
@@ -66,10 +67,11 @@ exports[`azure-prepare - Trigger Tests Trigger Keywords Snapshot skill keywords
6667
"hosting",
6768
"identity",
6869
"infrastructure",
69-
"migrate",
70-
"migration",
7170
"modernize",
71+
"move",
72+
"on-premises",
7273
"prepare",
74+
"scenarios",
7375
"security",
7476
"service",
7577
"terraform",

0 commit comments

Comments
 (0)